Bug 45323 - Update Windows LayoutTest/compositing results
Summary: Update Windows LayoutTest/compositing results
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-07 14:39 PDT by Simon Fraser (smfr)
Modified: 2010-09-10 13:39 PDT (History)
4 users (show)

See Also:

Attachments
Patch (17.97 KB, patch)
2010-09-07 14:49 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (17.97 KB, patch)
2010-09-07 14:57 PDT, Simon Fraser (smfr) 		cmarrin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2010-09-07 14:39:42 PDT 
A number of results under LayoutTest/compositing are wrong, and need to be updated.
Comment 1 Simon Fraser (smfr) 2010-09-07 14:49:47 PDT 
Created attachment 66767 [details]
Patch
Comment 2 WebKit Review Bot 2010-09-07 14:53:02 PDT 
Attachment 66767 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
LayoutTests/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Fraser (smfr) 2010-09-07 14:57:00 PDT 
Created attachment 66769 [details]
Patch
Comment 4 Chris Marrin 2010-09-07 18:09:53 PDT 
This is the right patch for now, to get the tests working. But we need to fix layerTreeAsText(), which is https://bugs.webkit.org/show_bug.cgi?id=39541
Comment 5 Chris Marrin 2010-09-07 18:10:12 PDT 
Comment on attachment 66769 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=66769&action=prettypatch

r=me
Comment 6 Simon Fraser (smfr) 2010-09-10 10:16:29 PDT 
http://trac.webkit.org/changeset/67212
Comment 7 WebKit Review Bot 2010-09-10 13:39:27 PDT 
http://trac.webkit.org/changeset/67212 might have broken Leopard Intel Debug (Tests)
The following changes are on the blame list:
http://trac.webkit.org/changeset/67211
http://trac.webkit.org/changeset/67212