Bug 45315

Summary:

Enable incremental results.json generation for non-layout tests.

Product:

WebKit

Reporter:

Kinuko Yasuda <kinuko>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ojan, victorw

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	ojan: review+

Kinuko Yasuda

Reported 2010-09-07 11:58:38 PDT

Enable incremental results.json generation for non-layout tests. Also need to add a functionality to upload the results to the app-engine's test results server.

Attachments
Patch (6.74 KB, patch) 2010-09-07 12:26 PDT, Kinuko Yasuda	ojan: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Kinuko Yasuda

Comment 1 2010-09-07 12:26:19 PDT

Created attachment 66748 [details] Patch

Victor Wang

Comment 2 2010-09-07 17:05:58 PDT

Comment on attachment 66748 [details] Patch > + json_files = ["incremental_results.json"] replace "incremental_results.json" with INCREMENTAL_RESULTS_FILENAME

Ojan Vafai

Comment 3 2010-09-07 17:07:33 PDT

Comment on attachment 66748 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=66748&action=prettypatch Just a few nits. > WebKitTools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:296 > + print results_file_url Did you mean to include this? > WebKitTools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:532 > + self._builder_name, self._test_results_server) Indentation is off. Have a couple extra spaces. > WebKitTools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:595 > + # Generate the JSON with incrementa flag enabled. Typo: incrementa

Kinuko Yasuda

Comment 4 2010-09-07 22:54:56 PDT

Committed r66953: <http://trac.webkit.org/changeset/66953>

Note You need to log in before you can comment on or make changes to this bug.