Bug 45314

Summary: Remove some unnecessary duplicate calls to string functions
Product: WebKit Reporter: Robert Hogan <robert>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 45240    
Attachments:
Description Flags
Patch none

Robert Hogan
Reported 2010-09-07 11:44:37 PDT
Replace calls of the sort : StringImpl::create(buffer.toUtf8().constData(), buffer.toUtf8().length()) with QByteArray ba = buffer.toUtf8(); return StringImpl::create(ba.constData(), ba.length());
Attachments
Patch (3.38 KB, patch)
2010-09-07 11:48 PDT, Robert Hogan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Robert Hogan
Comment 1 2010-09-07 11:48:13 PDT
Created attachment 66747 [details] Patch
Antonio Gomes
Comment 2 2010-09-07 11:51:37 PDT
Comment on attachment 66747 [details] Patch ba? :)
WebKit Commit Bot
Comment 3 2010-09-08 13:58:09 PDT
Comment on attachment 66747 [details] Patch Clearing flags on attachment: 66747 Committed r67012: <http://trac.webkit.org/changeset/67012>
WebKit Commit Bot
Comment 4 2010-09-08 13:58:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.