Summary: | [Qt] Symbian scoping in Qt build profile is wrong | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kristian Amlie <kristian.amlie> | ||||||
Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Major | CC: | ademar, commit-queue, hausmann | ||||||
Priority: | P2 | Keywords: | Qt, QtTriaged | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Comment on attachment 66644 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=66644&action=prettypatch Patch looks okay, but r- because of missing url to bugzilla in the ChangeLog and missing [Qt] as suffix "Fixed incorrect..." should be "[Qt] Fixed incorrect". Could you fix that? :) Created attachment 67001 [details]
Patch v2
Comment on attachment 67001 [details]
Patch v2
LGTM
Comment on attachment 67001 [details] Patch v2 Clearing flags on attachment: 67001 Committed r67080: <http://trac.webkit.org/changeset/67080> All reviewed patches have been landed. Closing bug. Revision r67080 cherry-picked into qtwebkit-2.1 with commit 20452c758fb66c9059d5ac540cd4aa0e3ecfab84 |
Created attachment 66644 [details] Patch The part in WebCore.pro that refers to missing install functionality is scoped under "symbian", however it should only apply to "symbian-abld" and "symbian-sbsv2".