|Summary:||[Qt] Symbian scoping in Qt build profile is wrong|
|Product:||WebKit||Reporter:||Kristian Amlie <kristian.amlie>|
|Component:||WebKit Qt||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Major||CC:||ademar, commit-queue, hausmann|
|Version:||528+ (Nightly build)|
Description Kristian Amlie 2010-09-06 07:51:38 PDT
Created attachment 66644 [details] Patch The part in WebCore.pro that refers to missing install functionality is scoped under "symbian", however it should only apply to "symbian-abld" and "symbian-sbsv2".
Comment 1 Simon Hausmann 2010-09-07 08:05:16 PDT
Comment on attachment 66644 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=66644&action=prettypatch Patch looks okay, but r- because of missing url to bugzilla in the ChangeLog and missing [Qt] as suffix "Fixed incorrect..." should be "[Qt] Fixed incorrect". Could you fix that? :)
Comment 4 WebKit Commit Bot 2010-09-09 05:05:19 PDT
Comment on attachment 67001 [details] Patch v2 Clearing flags on attachment: 67001 Committed r67080: <http://trac.webkit.org/changeset/67080>
Comment 5 WebKit Commit Bot 2010-09-09 05:05:24 PDT
All reviewed patches have been landed. Closing bug.
Comment 6 Ademar Reis 2010-09-09 13:50:39 PDT
Revision r67080 cherry-picked into qtwebkit-2.1 with commit 20452c758fb66c9059d5ac540cd4aa0e3ecfab84