Bug 45255

Summary: [reviewtool] Add an "ok" button that collapses review comments
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, fishd, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2010-09-06 03:51:48 PDT
[reviewtool] Add an "ok" button that collapses review comments
Attachments
Patch (2.85 KB, patch)
2010-09-06 03:55 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-09-06 03:55:33 PDT
Created attachment 66619 [details] Patch
Eric Seidel (no email)
Comment 2 2010-09-06 05:37:39 PDT
Comment on attachment 66619 [details] Patch Yay!
WebKit Commit Bot
Comment 3 2010-09-06 06:00:14 PDT
Comment on attachment 66619 [details] Patch Clearing flags on attachment: 66619 Committed r66821: <http://trac.webkit.org/changeset/66821>
WebKit Commit Bot
Comment 4 2010-09-06 06:00:18 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 5 2010-09-06 06:31:01 PDT
http://trac.webkit.org/changeset/66821 might have broken Qt Linux Release
Adam Barth
Comment 6 2010-09-06 10:23:48 PDT
I landed a follow up patch to handle an edge case better. http://trac.webkit.org/changeset/66838
Note You need to log in before you can comment on or make changes to this bug.