Bug 45255 - [reviewtool] Add an "ok" button that collapses review comments
Summary: [reviewtool] Add an "ok" button that collapses review comments
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-06 03:51 PDT by Adam Barth
Modified: 2010-09-06 10:23 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.85 KB, patch)
2010-09-06 03:55 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-09-06 03:51:48 PDT
[reviewtool] Add an "ok" button that collapses review comments
Comment 1 Adam Barth 2010-09-06 03:55:33 PDT
Created attachment 66619 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-09-06 05:37:39 PDT
Comment on attachment 66619 [details]
Patch

Yay!
Comment 3 WebKit Commit Bot 2010-09-06 06:00:14 PDT
Comment on attachment 66619 [details]
Patch

Clearing flags on attachment: 66619

Committed r66821: <http://trac.webkit.org/changeset/66821>
Comment 4 WebKit Commit Bot 2010-09-06 06:00:18 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Review Bot 2010-09-06 06:31:01 PDT
http://trac.webkit.org/changeset/66821 might have broken Qt Linux Release
Comment 6 Adam Barth 2010-09-06 10:23:48 PDT
I landed a follow up patch to handle an edge case better.

http://trac.webkit.org/changeset/66838