Bug 45246

Summary:

REGRESSION(66741): Undefined pthread macros

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ap, commit-queue, darin, eric, webkit.review.bot, zoltan

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Bug Depends on:

Bug Blocks:

43191

Attachments:

Description	Flags
proposed patch	none

Description Csaba Osztrogonác 2010-09-05 15:05:21 PDT

warning on Qt Linux Release bot:
../../../JavaScriptCore/wtf/FastMalloc.cpp:1496:5: warning: "PTHREAD_MUTEX_NORMAL" is not defined
../../../JavaScriptCore/wtf/FastMalloc.cpp:1496:29: warning: "PTHREAD_MUTEX_DEFAULT" is not defined

Comment 1 Alexey Proskuryakov 2010-09-05 17:29:13 PDT

Is Qt even using FastMalloc?

FWIW, we've been already using these macros in ThreadingPthreads.cpp.

Comment 2 Csaba Osztrogonác 2010-09-06 04:01:35 PDT

I cc-ed our memory expert. Zoltan, could you check it, please?

Comment 3 Zoltan Horvath 2010-09-06 05:53:37 PDT

(In reply to comment #1)
> Is Qt even using FastMalloc?

Yes, it is.

> FWIW, we've been already using these macros in ThreadingPthreads.cpp.

QtWebKit doesn't set PTHREADS macro, so we don't compile ThreadingPthreads.cpp.

Why do we need this

#if PTHREAD_MUTEX_NORMAL == PTHREAD_MUTEX_DEFAULT

condition? As I see these are defined as the same on mac and on linux as well (if it is even defined).

Comment 4 Darin Adler 2010-09-06 08:47:27 PDT

(In reply to comment #3)
> Why do we need this
> 
> #if PTHREAD_MUTEX_NORMAL == PTHREAD_MUTEX_DEFAULT
> 
> condition?

See bug 39893 for the reason.

Comment 5 Zoltan Horvath 2010-09-07 00:26:18 PDT

Created attachment 66687 [details]
proposed patch

Proposed patch for now. It's making the build happy.

Comment 6 WebKit Commit Bot 2010-09-07 08:16:40 PDT

Comment on attachment 66687 [details]
proposed patch

Clearing flags on attachment: 66687

Committed r66883: <http://trac.webkit.org/changeset/66883>

Comment 7 WebKit Commit Bot 2010-09-07 08:16:45 PDT

All reviewed patches have been landed.  Closing bug.

Comment 8 WebKit Review Bot 2010-09-07 10:26:34 PDT

http://trac.webkit.org/changeset/66883 might have broken Leopard Intel Debug (Tests)

Comment 9 Csaba Osztrogonác 2010-09-07 10:46:07 PDT

(In reply to comment #8)
> http://trac.webkit.org/changeset/66883 might have broken Leopard Intel Debug (Tests)

false positive alarm, it was a flakey test