Summary: | REGRESSION(66741): Undefined pthread macros | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, ap, commit-queue, darin, eric, webkit.review.bot, zoltan | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 43191 | ||||||
Attachments: |
|
Description
Csaba Osztrogonác
2010-09-05 15:05:21 PDT
Is Qt even using FastMalloc? FWIW, we've been already using these macros in ThreadingPthreads.cpp. I cc-ed our memory expert. Zoltan, could you check it, please? (In reply to comment #1) > Is Qt even using FastMalloc? Yes, it is. > FWIW, we've been already using these macros in ThreadingPthreads.cpp. QtWebKit doesn't set PTHREADS macro, so we don't compile ThreadingPthreads.cpp. Why do we need this #if PTHREAD_MUTEX_NORMAL == PTHREAD_MUTEX_DEFAULT condition? As I see these are defined as the same on mac and on linux as well (if it is even defined). (In reply to comment #3) > Why do we need this > > #if PTHREAD_MUTEX_NORMAL == PTHREAD_MUTEX_DEFAULT > > condition? See bug 39893 for the reason. Created attachment 66687 [details]
proposed patch
Proposed patch for now. It's making the build happy.
Comment on attachment 66687 [details] proposed patch Clearing flags on attachment: 66687 Committed r66883: <http://trac.webkit.org/changeset/66883> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/66883 might have broken Leopard Intel Debug (Tests) (In reply to comment #8) > http://trac.webkit.org/changeset/66883 might have broken Leopard Intel Debug (Tests) false positive alarm, it was a flakey test |