Bug 45230

Summary: [GTK] When a feature is disabled by default, the source necessary to build it are not included in the distribution
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: pnormand
Priority: P3 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on: 45302    
Bug Blocks:    
Attachments:
Description Flags
Fix make dist
none
Patch for this issue minus feature guard changes xan.lopez: review+

Martin Robinson
Reported 2010-09-04 11:52:33 PDT
For features that are disabled by default (such as indexed databases), the sources necessary to build those features are not included in the release distribution. This is because those features are not in the SOURCES primary. Most of these source files are guarded by #ifdefs. We should gradually fix the ones that aren't and move everything to the SOURCES primary.
Attachments
Fix make dist (168.75 KB, patch)
2010-09-04 12:48 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch for this issue minus feature guard changes (153.47 KB, patch)
2010-09-07 09:52 PDT, Martin Robinson 		xan.lopez: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2010-09-04 12:48:44 PDT
Created attachment 66588 [details] Fix make dist
Gustavo Noronha (kov)
Comment 2 2010-09-06 11:04:23 PDT
Comment on attachment 66588 [details] Fix make dist I don't claim to have checked every single line, but it looks sensible to me, it's the build system, and we already discussed this idea on IRC, so I'll say go!
Martin Robinson
Comment 3 2010-09-06 11:10:52 PDT
Since this touches some GStreamer code, I should probably have Philippe double-check my changes there.
Philippe Normand
Comment 4 2010-09-06 11:18:28 PDT
(In reply to comment #3) > Since this touches some GStreamer code, I should probably have Philippe double-check my changes there. I am totally fine with the guards added in the gstreamer/ files. Apologies for having forgotten them in the files I created.
Martin Robinson
Comment 5 2010-09-07 09:41:45 PDT
Xan suggested that I split this patch in two, so I'll be posting just the GNUmakefile.am changes shortly.
Martin Robinson
Comment 6 2010-09-07 09:52:32 PDT
Created attachment 66731 [details] Patch for this issue minus feature guard changes
Xan Lopez
Comment 7 2010-09-07 10:01:20 PDT
Comment on attachment 66731 [details] Patch for this issue minus feature guard changes - -# Clean rules for WebCore - -CLEANFILES += \ - libWebCoreJS.la This seems an unrelated leftover, everything else looks ok.
Martin Robinson
Comment 8 2010-09-13 09:37:20 PDT
Committed r67392: <http://trac.webkit.org/changeset/67392>
Note You need to log in before you can comment on or make changes to this bug.