Bug 45229

Summary:

GTK Skipped list should allow a directory to be listed when a feature is not supported

Product:

WebKit

Reporter:

Steve Block <steveblock>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, eric, jorlow, webkit.review.bot, zan

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Linux

Attachments:

Description	Flags
Patch	none

Steve Block

Reported 2010-09-04 11:20:11 PDT

Currently, the GTK Skipped list states that all tests should be listed explicitly, without grouping. We should make an exception for the case when an entire directory of tests is to be skipped due to the feature being unsupported. This eliminates the need to continually update the list when new tests for the feature are added.

Attachments
Patch (2.19 KB, patch) 2010-09-04 11:22 PDT, Steve Block	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Steve Block

Comment 1 2010-09-04 11:22:34 PDT

Created attachment 66585 [details] Patch

Martin Robinson

Comment 2 2010-09-04 14:11:16 PDT

Comment on attachment 66585 [details] Patch LGTM.

WebKit Commit Bot

Comment 3 2010-09-04 16:28:30 PDT

Comment on attachment 66585 [details] Patch Clearing flags on attachment: 66585 Committed r66798: <http://trac.webkit.org/changeset/66798>

WebKit Commit Bot

Comment 4 2010-09-04 16:28:34 PDT

All reviewed patches have been landed. Closing bug.

WebKit Review Bot

Comment 5 2010-09-04 17:20:52 PDT

http://trac.webkit.org/changeset/66798 might have broken Qt Linux Release

Note You need to log in before you can comment on or make changes to this bug.