Bug 45220

Summary: REGRESSION(r66781): Breaks the build. Adds a mac-specific file to platform/graphics without #if PLATFORM() guards and changes the GraphicsContext3D interface without updating all implementations (Requested by jamesr on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: WebKit Review Bot <webkit.review.bot>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, jamesr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 30625    
Attachments:
Description Flags
ROLLOUT of r66781 none

WebKit Review Bot
Reported 2010-09-03 18:10:04 PDT
http://trac.webkit.org/changeset/66781 broke the build: Breaks the build. Adds a mac-specific file to platform/graphics without #if PLATFORM() guards and changes the GraphicsContext3D interface without updating all implementations (Requested by jamesr on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear
Attachments
ROLLOUT of r66781 (103.22 KB, patch)
2010-09-03 18:10 PDT, WebKit Review Bot
no flags
WebKit Review Bot
Comment 1 2010-09-03 18:10:18 PDT
Created attachment 66576 [details] ROLLOUT of r66781 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID --ignore-builders where ATTACHMENT_ID is the ID of this attachment.
James Robinson
Comment 2 2010-09-03 18:13:47 PDT
Comment on attachment 66576 [details] ROLLOUT of r66781 landing by hand.
James Robinson
Comment 3 2010-09-03 18:16:04 PDT
Comment on attachment 66576 [details] ROLLOUT of r66781 Clearing flags on attachment: 66576 Committed r66783: <http://trac.webkit.org/changeset/66783>
James Robinson
Comment 4 2010-09-03 18:16:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.