Bug 45220 - REGRESSION(r66781): Breaks the build. Adds a mac-specific file to platform/graphics without #if PLATFORM() guards and changes the GraphicsContext3D interface without updating all implementations (Requested by jamesr on #webkit).
Summary: REGRESSION(r66781): Breaks the build. Adds a mac-specific file to platform/gr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: WebKit Review Bot
URL:
Keywords:
Depends on:
Blocks: 30625
  Show dependency tree / graph
 
Reported: 2010-09-03 18:10 PDT by WebKit Review Bot
Modified: 2010-09-03 18:16 PDT (History)
2 users (show)

See Also:

Attachments
ROLLOUT of r66781 (103.22 KB, patch)
2010-09-03 18:10 PDT, WebKit Review Bot 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2010-09-03 18:10:04 PDT 
http://trac.webkit.org/changeset/66781 broke the build:
Breaks the build. Adds a mac-specific file to platform/graphics without #if PLATFORM() guards and changes the GraphicsContext3D interface without updating all implementations (Requested by jamesr on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2010-09-03 18:10:18 PDT 
Created attachment 66576 [details]
ROLLOUT of r66781

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 James Robinson 2010-09-03 18:13:47 PDT 
Comment on attachment 66576 [details]
ROLLOUT of r66781

landing by hand.
Comment 3 James Robinson 2010-09-03 18:16:04 PDT 
Comment on attachment 66576 [details]
ROLLOUT of r66781

Clearing flags on attachment: 66576

Committed r66783: <http://trac.webkit.org/changeset/66783>
Comment 4 James Robinson 2010-09-03 18:16:08 PDT 
All reviewed patches have been landed.  Closing bug.