Bug 45211

Summary: Add AudioDSPKernelProcessor files
Product: WebKit Reporter: Chris Rogers <crogers>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, commit-queue, dglazkov, eric.carlson, japhet, jer.noble, kbr, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Chris Rogers
Reported 2010-09-03 15:55:57 PDT
Add AudioDSPKernelProcessor files
Attachments
Patch (8.42 KB, patch)
2010-09-03 15:57 PDT, Chris Rogers 		no flags
DetailsFormatted DiffDiff
Patch (8.44 KB, patch)
2010-09-07 13:36 PDT, Chris Rogers 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Rogers
Comment 1 2010-09-03 15:57:49 PDT
Created attachment 66561 [details] Patch
Chris Rogers
Comment 2 2010-09-07 13:36:41 PDT
Created attachment 66758 [details] Patch
Kenneth Russell
Comment 3 2010-09-09 14:32:21 PDT
Comment on attachment 66758 [details] Patch Looks fine to me. I hope that the JavaScript code which drives some of these classes can't trigger the assertions throughout this code simply by reconfiguring the audio graph, and that the assertions firing would imply a bug in the audio engine itself.
Chris Rogers
Comment 4 2010-09-09 14:55:14 PDT
Ken, all assertions are meant to catch bugs in the actual code. Exceptions will be used for anything bad which JavaScript code could itself possibly trigger.
WebKit Commit Bot
Comment 5 2010-09-09 15:48:46 PDT
Comment on attachment 66758 [details] Patch Clearing flags on attachment: 66758 Committed r67121: <http://trac.webkit.org/changeset/67121>
WebKit Commit Bot
Comment 6 2010-09-09 15:48:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.