Bug 45204

Summary: Add AudioArray.h
Product: WebKit Reporter: Chris Rogers <crogers>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, dglazkov, eric.carlson, japhet, jer.noble, kbr, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Chris Rogers
Reported 2010-09-03 14:49:28 PDT
Add AudioArray.h
Attachments
Patch (3.53 KB, patch)
2010-09-03 14:50 PDT, Chris Rogers 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Rogers
Comment 1 2010-09-03 14:50:42 PDT
Created attachment 66547 [details] Patch
Kenneth Russell
Comment 2 2010-09-07 17:30:22 PDT
Comment on attachment 66547 [details] Patch Looks good to me. One comment not necessarily requiring action. View in context: https://bugs.webkit.org/attachment.cgi?id=66547&action=prettypatch > WebCore/platform/audio/AudioArray.h:55 > + void copyToRange(T* sourceData, unsigned start, unsigned end) If you have situations elsewhere in your code where you would pass e.g. AudioFloatArray.data() as the first argument to copyToRange, then it would be good to add another overloaded version of copyToRange which can also verify that the source array has enough elements to cover the copy operation.
Chris Rogers
Comment 3 2010-09-07 17:48:37 PDT
Comment on attachment 66547 [details] Patch Clearing flags on attachment: 66547 Committed r66938: <http://trac.webkit.org/changeset/66938>
Chris Rogers
Comment 4 2010-09-07 17:48:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.