| Summary: | Web Inspector: Cleanup after r66117 - extract heap snapshot view styles into a dedicated .css | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mikhail Naganov <mnaganov> | ||||
| Component: | Web Inspector (Deprecated) | Assignee: | Mikhail Naganov <mnaganov> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
Created attachment 66512 [details]
Proposed patch
Attachment 66512 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/ChangeLog:6: Line contains tab character. [whitespace/tab] [5]
Total errors found: 1 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 66512 [details]
Proposed patch
Please resolve style errors before landing.
Manually committed https://trac.webkit.org/changeset/66739 2010-09-03 Mikhail Naganov < mnaganov@chromium.org> Reviewed by Yury Semikhatsky. Web Inspector: Cleanup after r66117 - extract heap snapshot view styles into a dedicated .css https://bugs.webkit.org/show_bug.cgi?id=45178 WebCore.gypi: WebCore.vcproj/WebCore.vcproj: inspector/front-end/WebKit.qrc: inspector/front-end/heapProfiler.css: Added. (.heap-snapshot-sidebar-tree-item .icon): (.heap-snapshot-sidebar-tree-item.small .icon): (.heap-snapshot-view): (.heap-snapshot-view.visible): (.heap-snapshot-view .data-grid): (.heap-snapshot-view .data-grid th.count-column): (.heap-snapshot-view .data-grid td.count-column): (.heap-snapshot-view .data-grid th.size-column): (.heap-snapshot-view .data-grid td.size-column): (.heap-snapshot-view .data-grid th.countDelta-column): (.heap-snapshot-view .data-grid td.countDelta-column): (.heap-snapshot-view .data-grid th.sizeDelta-column): (.heap-snapshot-view .data-grid td.sizeDelta-column): (#heap-snapshot-summary-container): (.heap-snapshot-summary): (.heap-snapshot-summary canvas.summary-graph): (.heap-snapshot-summary-label): inspector/front-end/inspector.css: inspector/front-end/inspector.html: |
Pavel's comment: WebCore/inspector/front-end/inspector.css:3915 + .heap-snapshot-sidebar-tree-item .icon { Please introduce a separate file "heap-profiler.css" instead. Can be done in immediate follow-up.