Bug 45178 - Web Inspector: Cleanup after r66117 - extract heap snapshot view styles into a dedicated .css
Summary: Web Inspector: Cleanup after r66117 - extract heap snapshot view styles into ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mikhail Naganov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-03 10:01 PDT by Mikhail Naganov
Modified: 2010-11-03 09:25 PDT (History)
10 users (show)

See Also:


Attachments
Proposed patch (10.56 KB, patch)
2010-09-03 10:04 PDT, Mikhail Naganov
yurys: review+
yurys: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Naganov 2010-09-03 10:01:42 PDT
Pavel's comment:
  
  WebCore/inspector/front-end/inspector.css:3915
   +  .heap-snapshot-sidebar-tree-item .icon {
  Please introduce a separate file "heap-profiler.css" instead. Can be done in immediate follow-up.
Comment 1 Mikhail Naganov 2010-09-03 10:04:10 PDT
Created attachment 66512 [details]
Proposed patch
Comment 2 WebKit Review Bot 2010-09-03 10:06:19 PDT
Attachment 66512 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Yury Semikhatsky 2010-09-03 10:08:20 PDT
Comment on attachment 66512 [details]
Proposed patch

Please resolve style errors before landing.
Comment 4 Mikhail Naganov 2010-11-03 09:25:45 PDT
Manually committed https://trac.webkit.org/changeset/66739

2010-09-03 Mikhail Naganov < mnaganov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Cleanup after r66117 - extract heap snapshot
view styles into a dedicated .css
 https://bugs.webkit.org/show_bug.cgi?id=45178
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/front-end/WebKit.qrc:
inspector/front-end/heapProfiler.css: Added.
(.heap-snapshot-sidebar-tree-item .icon):
(.heap-snapshot-sidebar-tree-item.small .icon):
(.heap-snapshot-view):
(.heap-snapshot-view.visible):
(.heap-snapshot-view .data-grid):
(.heap-snapshot-view .data-grid th.count-column):
(.heap-snapshot-view .data-grid td.count-column):
(.heap-snapshot-view .data-grid th.size-column):
(.heap-snapshot-view .data-grid td.size-column):
(.heap-snapshot-view .data-grid th.countDelta-column):
(.heap-snapshot-view .data-grid td.countDelta-column):
(.heap-snapshot-view .data-grid th.sizeDelta-column):
(.heap-snapshot-view .data-grid td.sizeDelta-column):
(#heap-snapshot-summary-container):
(.heap-snapshot-summary):
(.heap-snapshot-summary canvas.summary-graph):
(.heap-snapshot-summary-label):
inspector/front-end/inspector.css:
inspector/front-end/inspector.html: