Summary: | Add unit tests for interval tree | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kenneth Russell <kbr> | ||||
Component: | WebCore Misc. | Assignee: | Kenneth Russell <kbr> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, cmarrin, dglazkov, eric, fishd, sam, simon.fraser, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | 45060, 45160 | ||||||
Bug Blocks: | 44729 | ||||||
Attachments: |
|
Description
Kenneth Russell
2010-09-02 19:41:22 PDT
Created attachment 66465 [details] Patch This patch won't build until bug 45060 and bug 45160 land, but it should give reviewers an idea of how the tree has been tested. Attachment 66465 [details] did not build on chromium: Build output: http://queues.webkit.org/results/3924063 Comment on attachment 66465 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=66465&action=prettypatch > WebKit/chromium/tests/PODIntervalTreeTest.cpp:109 > +namespace { nit: add new line after "namespace {" to match the new line above the closing bracket > WebKit/chromium/tests/PODIntervalTreeTest.cpp:150 > +namespace { nit: add new line below this line > WebKit/chromium/tests/PODIntervalTreeTest.cpp:199 > + int len = nextRandom(maximumValue); nit: len -> length > WebKit/chromium/tests/PODIntervalTreeTest.cpp:210 > + int idx = nextRandom(addedElements.size()); nit: idx -> index R=me w/ those nits fixed Committed r66809: <http://trac.webkit.org/changeset/66809> http://trac.webkit.org/changeset/66809 might have broken Leopard Intel Debug (Tests) |