Bug 45161

Summary: Add unit tests for interval tree
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebCore Misc.Assignee: Kenneth Russell <kbr>
Severity: Normal CC: abarth, cmarrin, dglazkov, eric, fishd, sam, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 45060, 45160    
Bug Blocks: 44729    
Description Flags
Patch fishd: review+, kbr: commit-queue-

Description Kenneth Russell 2010-09-02 19:41:22 PDT
The interval tree being integrated in https://bugs.webkit.org/show_bug.cgi?id=45160 needs unit tests integrated as well.
Comment 1 Kenneth Russell 2010-09-02 20:07:07 PDT
Created attachment 66465 [details]

This patch won't build until bug 45060 and bug 45160 land, but it should give reviewers an idea of how the tree has been tested.
Comment 2 WebKit Review Bot 2010-09-03 02:07:12 PDT
Attachment 66465 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/3924063
Comment 3 Darin Fisher (:fishd, Google) 2010-09-03 16:48:17 PDT
Comment on attachment 66465 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=66465&action=prettypatch

> WebKit/chromium/tests/PODIntervalTreeTest.cpp:109
> +namespace {
nit: add new line after "namespace {" to match the new line above the closing bracket

> WebKit/chromium/tests/PODIntervalTreeTest.cpp:150
> +namespace {
nit: add new line below this line

> WebKit/chromium/tests/PODIntervalTreeTest.cpp:199
> +        int len = nextRandom(maximumValue);
nit: len -> length

> WebKit/chromium/tests/PODIntervalTreeTest.cpp:210
> +        int idx = nextRandom(addedElements.size());
nit: idx -> index

R=me w/ those nits fixed
Comment 4 Kenneth Russell 2010-09-05 21:54:20 PDT
Committed r66809: <http://trac.webkit.org/changeset/66809>
Comment 5 WebKit Review Bot 2010-09-05 23:15:58 PDT
http://trac.webkit.org/changeset/66809 might have broken Leopard Intel Debug (Tests)