Bug 45129

Summary:

[GTK] ignore po~ files in .gitignore

Product:

WebKit

Reporter:

arno. <a.renevier>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alex, commit-queue, gustavo, mrobinson

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
patch v1	none
patch v1.1	none

Description arno. 2010-09-02 14:01:25 PDT

Hi,
after building webkit-gtk, a few .po~ files are reported as untracked by git status
file WebKit/gtk/po/webkit-2.0.pot  is also reported as untracked by git status

Comment 1 arno. 2010-09-02 14:07:08 PDT

Created attachment 66409 [details]
patch v1

Comment 2 Martin Robinson 2010-09-03 09:49:37 PDT

If possible it would be great to get these to generate in the build directory.

Comment 3 arno. 2010-09-04 11:14:45 PDT

I can't find how those .po~ are created
I think that must be in WebKit/gtk/po/GNUmakefile.am
but which command create them ?

Comment 4 Martin Robinson 2010-09-04 11:19:03 PDT

I've CC'd Alex, who has done some work with the po files in the past.

Comment 5 Gustavo Noronha (kov) 2010-09-06 11:00:50 PDT

Two ideas: why not ignore all *~ files, given those are usually generated by popular editors such as Emacs? Also, we should ignore WebKit/gtk/po/*.pot, because the name of the pot file may change depending on the version of the library that is being build (with gtk2 or 3)

Comment 6 Martin Robinson 2010-09-06 11:04:02 PDT

(In reply to comment #5)
> Two ideas: why not ignore all *~ files, given those are usually generated by popular editors such as Emacs?

I think this is a great idea.

> Also, we should ignore WebKit/gtk/po/*.pot, because the name of the pot file may change depending on the version of the library that is being build (with gtk2 or 3)

Agree with this as well, though I believe we can get it to generate in WebKitBuild still. For now I think it's probably fine to ignore it where it is.

Comment 7 arno. 2010-09-06 12:52:08 PDT

Created attachment 66666 [details]
patch v1.1

(In reply to comment #5)
> Two ideas: why not ignore all *~ files, given those are usually generated by popular editors such as Emacs? Also, we should ignore WebKit/gtk/po/*.pot, because the name of the pot file may change depending on the version of the library that is being build (with gtk2 or 3)

Should we ignore *~ globally or just for gtk ?
here is an updated patch ignoring *~ globally.

Comment 8 Holger Freyther 2010-09-07 00:55:50 PDT

Comment on attachment 66666 [details]
patch v1.1

Looks good. Nice patch number.

Comment 9 WebKit Commit Bot 2010-09-07 02:12:33 PDT

Comment on attachment 66666 [details]
patch v1.1

Clearing flags on attachment: 66666

Committed r66870: <http://trac.webkit.org/changeset/66870>

Comment 10 WebKit Commit Bot 2010-09-07 02:12:37 PDT

All reviewed patches have been landed.  Closing bug.