Bug 45129

Summary:

[GTK] ignore po~ files in .gitignore

Product:

WebKit

Reporter:

arno. <a.renevier>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alex, commit-queue, gustavo, mrobinson

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
patch v1	none
patch v1.1	none

arno.

Reported 2010-09-02 14:01:25 PDT

Hi, after building webkit-gtk, a few .po~ files are reported as untracked by git status file WebKit/gtk/po/webkit-2.0.pot is also reported as untracked by git status

Attachments
patch v1 (1003 bytes, patch) 2010-09-02 14:07 PDT, arno.	no flags	Details Formatted Diff Diff
patch v1.1 (1.22 KB, patch) 2010-09-06 12:52 PDT, arno.	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

arno.

Comment 1 2010-09-02 14:07:08 PDT

Created attachment 66409 [details] patch v1

Martin Robinson

Comment 2 2010-09-03 09:49:37 PDT

If possible it would be great to get these to generate in the build directory.

arno.

Comment 3 2010-09-04 11:14:45 PDT

I can't find how those .po~ are created I think that must be in WebKit/gtk/po/GNUmakefile.am but which command create them ?

Martin Robinson

Comment 4 2010-09-04 11:19:03 PDT

I've CC'd Alex, who has done some work with the po files in the past.

Gustavo Noronha (kov)

Comment 5 2010-09-06 11:00:50 PDT

Two ideas: why not ignore all *~ files, given those are usually generated by popular editors such as Emacs? Also, we should ignore WebKit/gtk/po/*.pot, because the name of the pot file may change depending on the version of the library that is being build (with gtk2 or 3)

Martin Robinson

Comment 6 2010-09-06 11:04:02 PDT

(In reply to comment #5) > Two ideas: why not ignore all *~ files, given those are usually generated by popular editors such as Emacs? I think this is a great idea. > Also, we should ignore WebKit/gtk/po/*.pot, because the name of the pot file may change depending on the version of the library that is being build (with gtk2 or 3) Agree with this as well, though I believe we can get it to generate in WebKitBuild still. For now I think it's probably fine to ignore it where it is.

arno.

Comment 7 2010-09-06 12:52:08 PDT

Created attachment 66666 [details] patch v1.1 (In reply to comment #5) > Two ideas: why not ignore all *~ files, given those are usually generated by popular editors such as Emacs? Also, we should ignore WebKit/gtk/po/*.pot, because the name of the pot file may change depending on the version of the library that is being build (with gtk2 or 3) Should we ignore *~ globally or just for gtk ? here is an updated patch ignoring *~ globally.

Holger Freyther

Comment 8 2010-09-07 00:55:50 PDT

Comment on attachment 66666 [details] patch v1.1 Looks good. Nice patch number.

WebKit Commit Bot

Comment 9 2010-09-07 02:12:33 PDT

Comment on attachment 66666 [details] patch v1.1 Clearing flags on attachment: 66666 Committed r66870: <http://trac.webkit.org/changeset/66870>

WebKit Commit Bot

Comment 10 2010-09-07 02:12:37 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.