Bug 45123

Summary:

Markup.waitUntilDone does not call Markup.noAutoDump without LayoutTestController

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, ojan, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	tkent: review+

Description Ryosuke Niwa 2010-09-02 12:52:32 PDT

At dump-as-markup.js#L90 we have:
Markup.waitUntilDone = function()
{
    layoutTestController.waitUntilDone();
    Markup.noAutoDump();
}

But if layoutTestController was undefined, we would error at L92 and will never call noAutoDump().

Comment 1 Ojan Vafai 2010-09-07 17:58:09 PDT

Created attachment 66810 [details]
Patch

Comment 2 Ojan Vafai 2010-09-07 18:27:05 PDT

Committed r66944: <http://trac.webkit.org/changeset/66944>