Bug 45123

Summary:

Markup.waitUntilDone does not call Markup.noAutoDump without LayoutTestController

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, ojan, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	tkent: review+

Ryosuke Niwa

Reported 2010-09-02 12:52:32 PDT

At dump-as-markup.js#L90 we have: Markup.waitUntilDone = function() { layoutTestController.waitUntilDone(); Markup.noAutoDump(); } But if layoutTestController was undefined, we would error at L92 and will never call noAutoDump().

Attachments
Patch (1.12 KB, patch) 2010-09-07 17:58 PDT, Ojan Vafai	tkent: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ojan Vafai

Comment 1 2010-09-07 17:58:09 PDT

Created attachment 66810 [details] Patch

Ojan Vafai

Comment 2 2010-09-07 18:27:05 PDT

Committed r66944: <http://trac.webkit.org/changeset/66944>

Note You need to log in before you can comment on or make changes to this bug.