Bug 45122

Summary: [EFL] Fix double addition of -fPIC
Product: WebKit Reporter: Lucas De Marchi <lucas.de.marchi>
Component: WebKit EFLAssignee: Lucas De Marchi <lucas.de.marchi>
Status: RESOLVED FIXED    
Severity: Normal CC: barbieri, commit-queue, kenneth, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Description Lucas De Marchi 2010-09-02 12:33:37 PDT 
[EFL] Fix double addition of -fPIC
Comment 1 Lucas De Marchi 2010-09-02 12:45:02 PDT 
Created attachment 66399 [details]
Patch
Comment 2 Antonio Gomes 2010-09-02 14:29:11 PDT 
Comment on attachment 66399 [details]
Patch

* cmake/WebKitHelpers.cmake: Add -fPIC flags iff SHARED_CORE=ON.


"iff" :#
Comment 3 Lucas De Marchi 2010-09-02 15:21:09 PDT 
(In reply to comment #2)
> (From update of attachment 66399 [details])
> * cmake/WebKitHelpers.cmake: Add -fPIC flags iff SHARED_CORE=ON.
> 
> 
> "iff" :#

It was intentional, meaning "if and only if". Setting cq+.
Comment 4 WebKit Commit Bot 2010-09-02 22:42:04 PDT 
Comment on attachment 66399 [details]
Patch

Clearing flags on attachment: 66399

Committed r66714: <http://trac.webkit.org/changeset/66714>
Comment 5 WebKit Commit Bot 2010-09-02 22:42:08 PDT 
All reviewed patches have been landed.  Closing bug.