Bug 45122

Summary:

[EFL] Fix double addition of -fPIC

Product:

WebKit

Reporter:

Lucas De Marchi <lucas.de.marchi>

Component:

WebKit EFL

Assignee:

Lucas De Marchi <lucas.de.marchi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barbieri, commit-queue, kenneth, tonikitoo

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none

Lucas De Marchi

Reported 2010-09-02 12:33:37 PDT

[EFL] Fix double addition of -fPIC

Attachments
Patch (2.11 KB, patch) 2010-09-02 12:45 PDT, Lucas De Marchi	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Lucas De Marchi

Comment 1 2010-09-02 12:45:02 PDT

Created attachment 66399 [details] Patch

Antonio Gomes

Comment 2 2010-09-02 14:29:11 PDT

Comment on attachment 66399 [details] Patch * cmake/WebKitHelpers.cmake: Add -fPIC flags iff SHARED_CORE=ON. "iff" :#

Lucas De Marchi

Comment 3 2010-09-02 15:21:09 PDT

(In reply to comment #2) > (From update of attachment 66399 [details]) > * cmake/WebKitHelpers.cmake: Add -fPIC flags iff SHARED_CORE=ON. > > > "iff" :# It was intentional, meaning "if and only if". Setting cq+.

WebKit Commit Bot

Comment 4 2010-09-02 22:42:04 PDT

Comment on attachment 66399 [details] Patch Clearing flags on attachment: 66399 Committed r66714: <http://trac.webkit.org/changeset/66714>

WebKit Commit Bot

Comment 5 2010-09-02 22:42:08 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.