Bug 45117

Summary: Add WKMutableDictionary API for WebKit2
Product: WebKit Reporter: Sam Weinig <sam>
Component: WebKit2Assignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch andersca: review+

Description Sam Weinig 2010-09-02 11:15:06 PDT
Add WKMutableDictionary API for WebKit2
Comment 1 Sam Weinig 2010-09-02 11:17:29 PDT
Created attachment 66388 [details]
Patch
Comment 2 WebKit Review Bot 2010-09-02 11:20:19 PDT
Attachment 66388 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/Shared/MutableDictionary.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:73:  More than one command on the same line  [whitespace/newline] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:90:  More than one command on the same line  [whitespace/newline] [4]
WebKit2/UIProcess/API/C/WKMutableDictionary.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 4 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Eric Seidel (no email) 2010-10-13 12:27:08 PDT
Attachment 66388 [details] was posted by a committer and has review+, assigning to Sam Weinig for commit.
Comment 4 Sam Weinig 2010-10-28 13:18:31 PDT
Landed in http://trac.webkit.org/changeset/66676.