Summary: | Add WKMutableDictionary API for WebKit2 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
Component: | WebKit2 | Assignee: | Sam Weinig <sam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Sam Weinig
2010-09-02 11:15:06 PDT
Created attachment 66388 [details]
Patch
Attachment 66388 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/Shared/MutableDictionary.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:73: More than one command on the same line [whitespace/newline] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:90: More than one command on the same line [whitespace/newline] [4]
WebKit2/UIProcess/API/C/WKMutableDictionary.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 4 in 13 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 66388 [details] was posted by a committer and has review+, assigning to Sam Weinig for commit.
Landed in http://trac.webkit.org/changeset/66676. |