Bug 45082

Summary: Add mutable array API to WebKit2
Product: WebKit Reporter: Sam Weinig <sam>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch aroben: review+

Sam Weinig
Reported 2010-09-01 19:16:32 PDT
Add mutable array API to WebKit2
Attachments
Patch (22.43 KB, patch)
2010-09-01 19:21 PDT, Sam Weinig 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2010-09-01 19:21:25 PDT
Created attachment 66313 [details] Patch
WebKit Review Bot
Comment 2 2010-09-01 19:27:16 PDT
Attachment 66313 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/UIProcess/API/C/WKAPICast.h:71: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:77: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:87: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKMutableArray.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/Shared/MutableArray.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 5 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Adam Roben (:aroben)
Comment 3 2010-09-01 20:37:00 PDT
Comment on attachment 66313 [details] Patch A comment giving an example of how the toWK function works would be great. r=me
Sam Weinig
Comment 4 2010-09-01 20:37:49 PDT
Landed in r66638.
WebKit Review Bot
Comment 5 2010-09-02 03:20:37 PDT
http://trac.webkit.org/changeset/66638 might have broken SnowLeopard Intel Release (Tests)
Note You need to log in before you can comment on or make changes to this bug.