Bug 45067

Summary: test failure: inspector/console-format.html
Product: WebKit Reporter: Matthew Willis (lilmatt) <lilmatt>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, bweinstein, commit-queue, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Fix failing test joepeck: review+, joepeck: commit-queue+

Matthew Willis (lilmatt)
Reported 2010-09-01 15:48:36 PDT
The test 'inspector/console-format.html' is failing. This is fallout from svn revision 66616.
Attachments
Fix failing test (1.81 KB, patch)
2010-09-01 15:57 PDT, Matthew Willis (lilmatt) 		joepeck: review+
joepeck: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matthew Willis (lilmatt)
Comment 1 2010-09-01 15:57:52 PDT
Created attachment 66295 [details] Fix failing test Fixes failing test caused by r66616
Joseph Pecoraro
Comment 2 2010-09-01 16:00:33 PDT
The diff shows: "Error: Unknown error" => "Error: " Which is what r66616 did as expected. http://trac.webkit.org/changeset/66616/trunk/JavaScriptCore/runtime/ErrorPrototype.cpp Sounds to me like we just need to check in updated results. it also looks like v8 already has the empty error message. So you could check to see if we can remove the chromium platform specific results after reseting the results: LayoutTests/platform/chromium/inspector/console-format-expected.txt
Joseph Pecoraro
Comment 3 2010-09-01 16:06:09 PDT
Comment on attachment 66295 [details] Fix failing test Looks good. Thanks! I'll see if this can get landed sooner than the commit queue.
Gavin Barraclough
Comment 4 2010-09-01 16:07:26 PDT
Ooops! apologies for the breakage, thank you for fixing.
Joseph Pecoraro
Comment 5 2010-09-01 16:27:58 PDT
Committed r66625 M LayoutTests/inspector/console-format-expected.txt M LayoutTests/ChangeLog r66625 = 2f15e0a53e38f4e30aeaf5ab4bc394f5c9ebca51 http://trac.webkit.org/changeset/66625
Note You need to log in before you can comment on or make changes to this bug.