Bug 45016 – [Chromium] Add WebKitClient::callOnMainThreadWithDelay()

• Component: WebKit API
• Status: RESOLVED INVALID

[Kent Tamura]

[Chromium] Add WebKitClient::callOnMainThreadWithDelay()

[Kent Tamura]

Created attachment 66164 [details]
Patch

[Dimitri Glazkov (Google)]

Comment on attachment 66164 [details]
Patch

ok. I am assuming you're adding callers of this after rolling chromium?

[Kent Tamura]

(In reply to comment #2)
> (From update of attachment 66164 [details])
> ok. I am assuming you're adding callers of this after rolling chromium?

Right.
1. commit this.
2. commit an implementation of callOnMainThreadWithDelay() in Chromium
3. roll Chromium revision and use callOnMainThreadWithDelay() in DRT

[Kent Tamura]

Comment on attachment 66164 [details]
Patch

Clearing flags on attachment: 66164

Committed r66576: <http://trac.webkit.org/changeset/66576>

[Kent Tamura]

All reviewed patches have been landed.  Closing bug.

[Darin Fisher (:fishd, Google)]

Comment on attachment 66164 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=66164&action=prettypatch

> WebKit/chromium/public/WebKitClient.h:263
> +    virtual void callOnMainThreadWithDelay(void (*func)(void*), void* context, long long delayMilliseconds) { }
delayMilliseconds does not need to be 'long long'.  a simple int would do here.

i'm curious... what are the consumers that require this?

[Kent Tamura]

(In reply to comment #6)
> (From update of attachment 66164 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=66164&action=prettypatch
> 
> > WebKit/chromium/public/WebKitClient.h:263
> > +    virtual void callOnMainThreadWithDelay(void (*func)(void*), void* context, long long delayMilliseconds) { }
> delayMilliseconds does not need to be 'long long'.  a simple int would do here.
> 
> i'm curious... what are the consumers that require this?

I used "long long" because MessageLoop::postDelayedTask() uses int64 though int is enough for my purpose.

http://trac.webkit.org/browser/trunk/WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp#L324 will be replaced with code using callOnMainThreadWithDelay().

[Kent Tamura]

I have change my mind :-)
The function can be implemented in webkit_support and we don't need to pollute WebKit API.
I'll revert r66576.

[Kent Tamura]

Reverted r66576 for reason:

This change is not needed.

Committed r66627: <http://trac.webkit.org/changeset/66627>