| Summary: | Add AudioSourceNode files | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Rogers <crogers> | ||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cmarrin, commit-queue, dglazkov, eric.carlson, japhet, jer.noble, kbr, simon.fraser | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
Chris Rogers
2010-08-31 17:26:28 PDT
Created attachment 66146 [details]
Patch
Here's the link to AudioSourceNode in the web audio API spec: http://chromium.googlecode.com/svn/trunk/samples/audio/specification/specification.html#AudioSourceNode-section This patch implements two attributes which are not in the spec. I either need to change the spec or change the implementation, but it will require some thought to determine how to best design this and I would like to land this, even if it involves adding a FIXME to reconcile API. Comment on attachment 66146 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=66146&action=prettypatch > WebCore/webaudio/AudioSourceNode.idl:34 > + readonly attribute AudioParam playbackRate; Why are these attributes not documented in the preliminary web audio API ( http://chromium.googlecode.com/svn/trunk/samples/audio/specification/specification.html#AudioSourceNode-section )? Created attachment 66973 [details]
Patch
Ok, I've moved the attributes out of this class to match the current specification. Comment on attachment 66973 [details]
Patch
Looks fine. Sorry I didn't see your note above when doing my initial review, though I think it's better to keep this class in line with the spec.
Comment on attachment 66973 [details] Patch Clearing flags on attachment: 66973 Committed r67157: <http://trac.webkit.org/changeset/67157> All reviewed patches have been landed. Closing bug. |