| Summary: | ews: Add support for EFL-EWS | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Leandro Pereira <leandro> | ||||
| Component: | New Bugs | Assignee: | Leandro Pereira <leandro> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, commit-queue, eric, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Leandro Pereira
2010-08-31 13:57:58 PDT
Created attachment 66100 [details]
Patch
Comment on attachment 66100 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=66100&action=prettypatch > WebKitTools/Scripts/webkitpy/tool/commands/earlywarningsystem.py:114 > +class EflEWS(AbstractEarlyWarningSystem): > + name = "efl-ews" > + port_name = "efl" Does the EFL port run on more than one platform? If so, you might want to consider a name like efl-win-ews. Once you pick a name, you're stuck with it. :) Comment on attachment 66100 [details] Patch Clearing flags on attachment: 66100 Committed r66564: <http://trac.webkit.org/changeset/66564> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/66564 might have broken GTK Linux 64-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/66561 http://trac.webkit.org/changeset/66562 http://trac.webkit.org/changeset/66563 http://trac.webkit.org/changeset/66564 (In reply to comment #5) > http://trac.webkit.org/changeset/66564 might have broken GTK Linux 64-bit Debug > The following changes are on the blame list: > http://trac.webkit.org/changeset/66561 > http://trac.webkit.org/changeset/66562 > http://trac.webkit.org/changeset/66563 > http://trac.webkit.org/changeset/66564 Looks like a false alarm. (In reply to comment #2) > Does the EFL port run on more than one platform? If so, you might want to consider a name like > efl-win-ews. Once you pick a name, you're stuck with it. :) Currently, only Linux is supported. EFL itself is portable, but I don't know if there are short-term plans to support other platforms. |