Bug 44982

Summary: ews: Add support for EFL-EWS
Product: WebKit Reporter: Leandro Pereira <leandro>
Component: New BugsAssignee: Leandro Pereira <leandro>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Leandro Pereira
Reported 2010-08-31 13:57:58 PDT
ews: Add support for EFL-EWS
Attachments
Patch (3.59 KB, patch)
2010-08-31 14:03 PDT, Leandro Pereira 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Leandro Pereira
Comment 1 2010-08-31 14:03:40 PDT
Created attachment 66100 [details] Patch
Adam Barth
Comment 2 2010-08-31 16:40:11 PDT
Comment on attachment 66100 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=66100&action=prettypatch > WebKitTools/Scripts/webkitpy/tool/commands/earlywarningsystem.py:114 > +class EflEWS(AbstractEarlyWarningSystem): > + name = "efl-ews" > + port_name = "efl" Does the EFL port run on more than one platform? If so, you might want to consider a name like efl-win-ews. Once you pick a name, you're stuck with it. :)
WebKit Commit Bot
Comment 3 2010-08-31 18:16:51 PDT
Comment on attachment 66100 [details] Patch Clearing flags on attachment: 66100 Committed r66564: <http://trac.webkit.org/changeset/66564>
WebKit Commit Bot
Comment 4 2010-08-31 18:16:55 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 5 2010-08-31 18:55:45 PDT
http://trac.webkit.org/changeset/66564 might have broken GTK Linux 64-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/66561 http://trac.webkit.org/changeset/66562 http://trac.webkit.org/changeset/66563 http://trac.webkit.org/changeset/66564
Leandro Pereira
Comment 6 2010-09-01 04:58:02 PDT
(In reply to comment #5) > http://trac.webkit.org/changeset/66564 might have broken GTK Linux 64-bit Debug > The following changes are on the blame list: > http://trac.webkit.org/changeset/66561 > http://trac.webkit.org/changeset/66562 > http://trac.webkit.org/changeset/66563 > http://trac.webkit.org/changeset/66564 Looks like a false alarm.
Leandro Pereira
Comment 7 2010-09-01 04:59:18 PDT
(In reply to comment #2) > Does the EFL port run on more than one platform? If so, you might want to consider a name like > efl-win-ews. Once you pick a name, you're stuck with it. :) Currently, only Linux is supported. EFL itself is portable, but I don't know if there are short-term plans to support other platforms.
Note You need to log in before you can comment on or make changes to this bug.