Summary: | [GTK] Leak in the GraphicsContextCairo drawPathShadow | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alejandro G. Castro <alex> | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | gustavo, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Alejandro G. Castro
2010-08-31 09:12:44 PDT
Created attachment 66062 [details]
Proposed patch
Comment on attachment 66062 [details]
Proposed patch
Can't we use a PlatformRefPtr/CairoRefPtr for this?
(In reply to comment #2) > (From update of attachment 66062 [details]) > Can't we use a PlatformRefPtr/CairoRefPtr for this? I've checked path is not already included, but I can do it in this same patch and use it, thanks for the comment. Created attachment 66198 [details]
Proposed patch
Added the GOwnPtrCairo code so we can use it in these situations.
Attachment 66198 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/platform/graphics/cairo/GOwnPtrCairo.h:31: cairo_path_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #5) > Attachment 66198 [details] did not pass style-queue: > > Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 > WebCore/platform/graphics/cairo/GOwnPtrCairo.h:31: cairo_path_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] > Total errors found: 1 in 4 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. Yep, it is a false positive. Opened bug 45032. Comment on attachment 66198 [details]
Proposed patch
Looks reasonable.
|