Summary: | [reviewtool] Allow reviewer to select lines of context by dragging over the line numbers | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric, zimmermann | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Adam Barth
2010-08-31 02:35:05 PDT
Created attachment 66024 [details]
Patch
Comment on attachment 66024 [details]
Patch
LGTM! So exciting.
Committed r66471: <http://trac.webkit.org/changeset/66471> Great work Adam, that's the stuff I was missing most! Now we should just move it over to "Review patch" :-) (In reply to comment #4) > Great work Adam, that's the stuff I was missing most! Thanks! :) > Now we should just move it over to "Review patch" :-) Let me polish a few things first. The delete button is way too inviting currently. I delete my comments way too often. Also, I need to get Darin on board before removing the existing "review patch." |