Bug 44936

Summary: [reviewtool] Allow reviewer to select lines of context by dragging over the line numbers
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch eric: review+, eric: commit-queue+

Adam Barth
Reported 2010-08-31 02:35:05 PDT
[reviewtool] Allow reviewer to select lines of context by dragging over the line numbers
Attachments
Patch (4.47 KB, patch)
2010-08-31 02:37 PDT, Adam Barth 		eric: review+
eric: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-08-31 02:37:33 PDT
Created attachment 66024 [details] Patch
Eric Seidel (no email)
Comment 2 2010-08-31 02:38:52 PDT
Comment on attachment 66024 [details] Patch LGTM! So exciting.
Adam Barth
Comment 3 2010-08-31 02:40:19 PDT
Committed r66471: <http://trac.webkit.org/changeset/66471>
Nikolas Zimmermann
Comment 4 2010-08-31 03:06:27 PDT
Great work Adam, that's the stuff I was missing most! Now we should just move it over to "Review patch" :-)
Adam Barth
Comment 5 2010-08-31 12:07:25 PDT
(In reply to comment #4) > Great work Adam, that's the stuff I was missing most! Thanks! :) > Now we should just move it over to "Review patch" :-) Let me polish a few things first. The delete button is way too inviting currently. I delete my comments way too often. Also, I need to get Darin on board before removing the existing "review patch."
Note You need to log in before you can comment on or make changes to this bug.