Bug 44936 - [reviewtool] Allow reviewer to select lines of context by dragging over the line numbers
Summary: [reviewtool] Allow reviewer to select lines of context by dragging over the l...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-31 02:35 PDT by Adam Barth
Modified: 2010-08-31 12:07 PDT (History)
2 users (show)

See Also:


Attachments
Patch (4.47 KB, patch)
2010-08-31 02:37 PDT, Adam Barth
eric: review+
eric: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-08-31 02:35:05 PDT
[reviewtool] Allow reviewer to select lines of context by dragging over the line numbers
Comment 1 Adam Barth 2010-08-31 02:37:33 PDT
Created attachment 66024 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-08-31 02:38:52 PDT
Comment on attachment 66024 [details]
Patch

LGTM!  So exciting.
Comment 3 Adam Barth 2010-08-31 02:40:19 PDT
Committed r66471: <http://trac.webkit.org/changeset/66471>
Comment 4 Nikolas Zimmermann 2010-08-31 03:06:27 PDT
Great work Adam, that's the stuff I was missing most!
Now we should just move it over to "Review patch" :-)
Comment 5 Adam Barth 2010-08-31 12:07:25 PDT
(In reply to comment #4)
> Great work Adam, that's the stuff I was missing most!

Thanks!  :)

> Now we should just move it over to "Review patch" :-)

Let me polish a few things first.  The delete button is way too inviting currently.  I delete my comments way too often.  Also, I need to get Darin on board before removing the existing "review patch."