Bug 44851

Summary: Create SVG and WML elements with create functions instead of direct invocations of new
Product: WebKit Reporter: Darin Adler <darin>
Component: SVGAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, dglazkov, eric, gustavo, mjs, webkit-ews, webkit.review.bot, xan.lopez, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 28068    
Attachments:
Description Flags
Patch
none
Patch mjs: review+

Darin Adler
Reported 2010-08-29 20:09:58 PDT
Create SVG and WML elements with create functions instead of direct invocations of new
Attachments
Patch (139.09 KB, patch)
2010-08-29 20:18 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (139.09 KB, patch)
2010-08-29 20:25 PDT, Darin Adler 		mjs: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2010-08-29 20:18:05 PDT
Created attachment 65872 [details] Patch
Darin Adler
Comment 2 2010-08-29 20:25:16 PDT
Created attachment 65873 [details] Patch
Early Warning System Bot
Comment 3 2010-08-29 20:34:07 PDT
Attachment 65872 [details] did not build on qt: Build output: http://queues.webkit.org/results/3882133
Eric Seidel (no email)
Comment 4 2010-08-29 20:45:07 PDT
Attachment 65872 [details] did not build on mac: Build output: http://queues.webkit.org/results/3815144
WebKit Review Bot
Comment 5 2010-08-29 21:00:51 PDT
Attachment 65872 [details] did not build on chromium: Build output: http://queues.webkit.org/results/3890031
Maciej Stachowiak
Comment 6 2010-08-29 21:48:20 PDT
Comment on attachment 65873 [details] Patch r=me Your ChangeLog comments imply that you left some constructors public, if so, why?
WebKit Review Bot
Comment 7 2010-08-29 21:53:47 PDT
Attachment 65872 [details] did not build on gtk: Build output: http://queues.webkit.org/results/3887113
Darin Adler
Comment 8 2010-08-29 23:03:37 PDT
(In reply to comment #6) > Your ChangeLog comments imply that you left some constructors public, if so, why? Just wanted to limit the size of the change this round. I’ll make sure to make all of the constructors private or protected before changing them to call adoptRef.
Darin Adler
Comment 9 2010-08-29 23:52:35 PDT
Committed r66362: <http://trac.webkit.org/changeset/66362>
Note You need to log in before you can comment on or make changes to this bug.