Bug 44851

Summary: Create SVG and WML elements with create functions instead of direct invocations of new
Product: WebKit Reporter: Darin Adler <darin>
Component: SVGAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, dglazkov, eric, gustavo, mjs, webkit-ews, webkit.review.bot, xan.lopez, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 28068    
Attachments:
Description Flags
Patch
none
Patch mjs: review+

Description Darin Adler 2010-08-29 20:09:58 PDT 
Create SVG and WML elements with create functions instead of direct invocations of new
Comment 1 Darin Adler 2010-08-29 20:18:05 PDT 
Created attachment 65872 [details]
Patch
Comment 2 Darin Adler 2010-08-29 20:25:16 PDT 
Created attachment 65873 [details]
Patch
Comment 3 Early Warning System Bot 2010-08-29 20:34:07 PDT 
Attachment 65872 [details] did not build on qt:
Build output: http://queues.webkit.org/results/3882133
Comment 4 Eric Seidel (no email) 2010-08-29 20:45:07 PDT 
Attachment 65872 [details] did not build on mac:
Build output: http://queues.webkit.org/results/3815144
Comment 5 WebKit Review Bot 2010-08-29 21:00:51 PDT 
Attachment 65872 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/3890031
Comment 6 Maciej Stachowiak 2010-08-29 21:48:20 PDT 
Comment on attachment 65873 [details]
Patch

r=me

Your ChangeLog comments imply that you left some constructors public, if so, why?
Comment 7 WebKit Review Bot 2010-08-29 21:53:47 PDT 
Attachment 65872 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/3887113
Comment 8 Darin Adler 2010-08-29 23:03:37 PDT 
(In reply to comment #6)
> Your ChangeLog comments imply that you left some constructors public, if so, why?

Just wanted to limit the size of the change this round. I’ll make sure to make all of the constructors private or protected before changing them to call adoptRef.
Comment 9 Darin Adler 2010-08-29 23:52:35 PDT 
Committed r66362: <http://trac.webkit.org/changeset/66362>