Bug 44843

Summary: REGRESSION(r66324): Fix warnings in editing/ApplyStyleCommand.cpp
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, eric, rniwa, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 43191    
Attachments:
Description Flags
proposed fix
none
proposed fix 2 none

Description Csaba Osztrogonác 2010-08-29 14:31:22 PDT
gcc warnings:
../../../WebCore/editing/ApplyStyleCommand.cpp:1209: warning: suggest parentheses around && within ||
../../../WebCore/editing/ApplyStyleCommand.cpp:1210: warning: suggest parentheses around && within ||
Comment 1 Csaba Osztrogonác 2010-08-29 14:33:29 PDT
Created attachment 65862 [details]
proposed fix
Comment 2 Ryosuke Niwa 2010-08-29 14:42:44 PDT
Comment on attachment 65862 [details]
proposed fix

> WebCore/editing/ApplyStyleCommand.cpp:1210
> +            || (equivalent.attribute && !element->hasAttribute(*equivalent.attribute)))
Looks good to me.  Sorry about the regression.
Comment 3 Csaba Osztrogonác 2010-08-29 14:47:48 PDT
(In reply to comment #2)
> Looks good to me.  Sorry about the regression.
Not problem, now it isn't a big problem, but we are going to 
treat warnings as errors on Qt port. (with gcc -Werror option)
After that all warnings will cause a build fail. 
( See https://bugs.webkit.org/show_bug.cgi?id=43191 )
Comment 4 Csaba Osztrogonác 2010-08-29 15:09:17 PDT
Comment on attachment 65862 [details]
proposed fix

Clearing flags on attachment: 65862

Committed r66338: <http://trac.webkit.org/changeset/66338>
Comment 5 Csaba Osztrogonác 2010-08-29 15:09:26 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2010-08-29 15:51:44 PDT
http://trac.webkit.org/changeset/66338 might have broken Qt Linux Release
Comment 7 Csaba Osztrogonác 2010-08-29 23:52:14 PDT
Created attachment 65884 [details]
proposed fix 2

Crazy gcc, there are one more warning in line 1208, but it reported line 1209 :
../../../WebCore/editing/ApplyStyleCommand.cpp:1209: warning: suggest parentheses around && within ||
Comment 8 Csaba Osztrogonác 2010-08-29 23:53:01 PDT
(In reply to comment #6)
> http://trac.webkit.org/changeset/66338 might have broken Qt Linux Release

No, it isn't.
Comment 9 Csaba Osztrogonác 2010-08-30 02:46:31 PDT
Comment on attachment 65884 [details]
proposed fix 2

Landed in http://trac.webkit.org/changeset/66378