Summary: | REGRESSION(r66324): Fix warnings in editing/ApplyStyleCommand.cpp | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, darin, eric, rniwa, tkent, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 43191 | ||||||||
Attachments: |
|
Description
Csaba Osztrogonác
2010-08-29 14:31:22 PDT
Created attachment 65862 [details]
proposed fix
Comment on attachment 65862 [details] proposed fix > WebCore/editing/ApplyStyleCommand.cpp:1210 > + || (equivalent.attribute && !element->hasAttribute(*equivalent.attribute))) Looks good to me. Sorry about the regression. (In reply to comment #2) > Looks good to me. Sorry about the regression. Not problem, now it isn't a big problem, but we are going to treat warnings as errors on Qt port. (with gcc -Werror option) After that all warnings will cause a build fail. ( See https://bugs.webkit.org/show_bug.cgi?id=43191 ) Comment on attachment 65862 [details] proposed fix Clearing flags on attachment: 65862 Committed r66338: <http://trac.webkit.org/changeset/66338> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/66338 might have broken Qt Linux Release Created attachment 65884 [details]
proposed fix 2
Crazy gcc, there are one more warning in line 1208, but it reported line 1209 :
../../../WebCore/editing/ApplyStyleCommand.cpp:1209: warning: suggest parentheses around && within ||
(In reply to comment #6) > http://trac.webkit.org/changeset/66338 might have broken Qt Linux Release No, it isn't. Comment on attachment 65884 [details] proposed fix 2 Landed in http://trac.webkit.org/changeset/66378 |