Bug 44835

Summary:

Awesomify pretty-diff based review tool

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, ojan, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
work-in-progress script	none
more work-in-progress	none
front-end mostly done (needs bugzilla integration)	none
potentially ready	none
Patch	eric: review+

Description Adam Barth 2010-08-29 00:55:16 PDT

The current pretty-diff review tool is ok.  We can make it much more awesome with a little work.  On the agenda:

1) Fix the "giant comment" bug.
2) View line-by-line comments in context.
3) Threaded line-by-line comments in patch.

Comment 1 Adam Barth 2010-08-29 00:55:43 PDT

Created attachment 65848 [details]
work-in-progress script

Comment 2 Adam Barth 2010-08-29 01:25:25 PDT

Created attachment 65849 [details]
more work-in-progress

Comment 3 Adam Barth 2010-08-29 02:09:40 PDT

Created attachment 65850 [details]
front-end mostly done (needs bugzilla integration)

Comment 4 Adam Barth 2010-08-29 09:43:19 PDT

Created attachment 65854 [details]
potentially ready

Comment 5 Adam Barth 2010-08-29 09:52:30 PDT

Created attachment 65855 [details]
Patch

Comment 6 Adam Barth 2010-08-29 09:53:16 PDT

This version don't have support for parsing back the threaded discussion, but I'll add that in the next patch.

Comment 7 Eric Seidel (no email) 2010-08-29 10:58:24 PDT

Comment on attachment 65855 [details]
Patch

I'm not sure I can really review much here.  Lets just try it, and change/rollout if it's wrong.

Comment 8 Adam Barth 2010-08-29 11:00:09 PDT

Committed r66332: <http://trac.webkit.org/changeset/66332>

Comment 9 Adam Barth 2010-08-29 11:06:22 PDT

Comment on attachment 65855 [details]
Patch

> BugsSite/ChangeLog:5
> +        Awesomify pretty-diff based review tool
This is a test.

Comment 10 WebKit Review Bot 2010-08-29 11:30:32 PDT

http://trac.webkit.org/changeset/66332 might have broken Qt Linux Release