Bug 44786

Summary: [chromium] Preparatory patch to split libwebcore in multiple libraries.
Product: WebKit Reporter: Marc-Antoine Ruel <maruel>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit.review.bot
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 44796    
Attachments:
Description Flags
webcore.gyp patch
none
no tabs none

Marc-Antoine Ruel
Reported 2010-08-27 12:31:51 PDT
Preparatory patch to split libwebcore in multiple libraries. Start with a webcore_prerequisites pseudo-target what will be the common target for all the other ones.
Attachments
webcore.gyp patch (3.47 KB, patch)
2010-08-27 12:32 PDT, Marc-Antoine Ruel 		no flags
DetailsFormatted DiffDiff
no tabs (3.48 KB, patch)
2010-08-27 12:50 PDT, Marc-Antoine Ruel 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Marc-Antoine Ruel
Comment 1 2010-08-27 12:32:41 PDT
Created attachment 65751 [details] webcore.gyp patch
WebKit Review Bot
Comment 2 2010-08-27 12:35:55 PDT
Attachment 65751 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/ChangeLog:7: Line contains tab character. [whitespace/tab] [5] WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Marc-Antoine Ruel
Comment 3 2010-08-27 12:50:06 PDT
Created attachment 65753 [details] no tabs
Dimitri Glazkov (Google)
Comment 4 2010-08-27 13:08:06 PDT
Comment on attachment 65753 [details] no tabs ok.
WebKit Commit Bot
Comment 5 2010-08-28 01:31:36 PDT
Comment on attachment 65753 [details] no tabs Clearing flags on attachment: 65753 Committed r66302: <http://trac.webkit.org/changeset/66302>
WebKit Commit Bot
Comment 6 2010-08-28 01:31:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.