Summary: | [GTK] ScrollbarThemeGtk should respond to theme changes | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Martin Robinson <mrobinson> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | Keywords: | Gtk | ||||
Priority: | P3 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Martin Robinson
2010-08-27 11:49:20 PDT
Created attachment 65746 [details]
Patch
Comment on attachment 65746 [details]
Patch
89 // If the theme changed, update the thickness of every scrollbar widget.
90 // The platform-independent scrollbar code isn't yet smart enough to
91 // get this information when it paints.
92 HashSet<Scrollbar*>::iterator end = gScrollbars->end();
93 for (HashSet<Scrollbar*>::iterator it = gScrollbars->begin(); it != end; ++it) {
94 Scrollbar* scrollbar = (*it);
Saying 'If the theme changed' seems to imply that we're depending on a conditional, but if we're in this function it's because the theme has changed, so I'd suggest only stating what is being done. Looks good otherwise!
> Saying 'If the theme changed' seems to imply that we're depending on a conditional, but if we're in this function it's because the theme has changed, so I'd suggest only stating what is being done. Looks good otherwise!
Okay. I'll fix this before landing. Thanks for the review. :)
Committed r66540: <http://trac.webkit.org/changeset/66540> |