| Summary: | [Qt] tst_QWebView::focusInputTypes() fails on MeeGo Handset with WebKit 2.1 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||||
| Component: | Tools / Tests | Assignee: | Benjamin Poulain <benjamin> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Major | CC: | ademar, commit-queue | ||||||
| Priority: | P2 | Keywords: | Qt, QtTriaged | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | Other | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 44675 | ||||||||
| Attachments: |
|
||||||||
|
Description
Benjamin Poulain
2010-08-27 05:21:34 PDT
Created attachment 65703 [details]
Make the test more robust
On my hardware, this fixes the problems with webView.inputMethodHints().
However, I still have random failures out of QVERIFY(webView.testAttribute(Qt::WA_InputMethodEnabled)). Those cannot be reproduced in gdb so I suspect a race condition. The test bot has a different environment, we'll see if this patch fixes the failure.
Comment on attachment 65703 [details]
Make the test more robust
Good work!
Comment on attachment 65703 [details] Make the test more robust Clearing flags on attachment: 65703 Committed r66298: <http://trac.webkit.org/changeset/66298> All reviewed patches have been landed. Closing bug. Revision r66298 cherry-picked into qtwebkit-2.1 with commit 7c8ea628dd2c7d5c05e1682059d6178b2f8bc7e6 Created attachment 68911 [details]
Improve the test further
The test still fails on the test bots for an unknown reason. I hope to get more info from the output with this patch while still improving the test.
Using QCOMPARE() instead of QVERIFY() will output the return value so will help identifying the issue. Adding the "hasFocus()" on each element will help identifying if the element got the focus at all on the device.
|