[chromium] Add support for non-text/non-URL types in event.dataTransfer

• Component: HTML Editing
• Status: RESOLVED FIXED

[Daniel Cheng]

Created attachment 65634 [details]
Preliminary patch for reference

This is the WebKit patch to add that support. http://crbug.com/31037 is for the Chromium changes. I'm currently uncertain of how to split up the change nicely; right now, it requires a simultaneous commit against the WebKit and Chromium repositories.

[Daniel Cheng]

Created attachment 65977 [details]
Patch

[Daniel Cheng]

The associated Chromium-side patch is at http://codereview.chromium.org/2868069/show. 
The Windows side for the Chromium patch is more or less complete (ClipboardWin::WriteData does need to be updated though). I am working on merging in the changes I've made to the Mac/Linux side.

I'm currently not sure how to land this patch once it gets past review; there's some dependencies from the browser on renderer side changes, and vise versa. There's also what (I suspect) is a layering violation in the EventSender/WebViewHost changes, so any suggestions on how to resolve that would be welcome.

[Tony Chang]

Comment on attachment 65977 [details]
Patch

dcheng and I discussed various ways to break this patch into smaller pieces.  r- for now, since this is pretty much unreviewable and not landable anyway (it would break chromium since it's an api change).

[Ryosuke Niwa]

Does this bug still exist?

[Daniel Cheng]

The various bits that this involves have landed and been in tree for some time now.

[Ryosuke Niwa]

Excellent!