[Chromium] Implement LayoutTestController::markerTextForListItem()

• Component: New Bugs
• Status: RESOLVED FIXED

[Dumitru Daniliuc]

Add markerTextForListItem() to Chromium's LayoutTestController.

[Dumitru Daniliuc]

Created attachment 65641 [details]
patch

WebKit's side of the patch. Chromium's side is at http://codereview.chromium.org/3213001.

[Darin Fisher (:fishd, Google)]

Comment on attachment 65641 [details]
patch

WebKit/chromium/public/WebFrame.h:522
 +      virtual WebString markerTextForListItem(const WebElement& webElement) const = 0;
nit: no parameter name here since the parameter name does not add information.

WebKit/chromium/src/WebFrameImpl.cpp:1696
 +      return WebCore::markerTextForListItem(element.get());
nit: change this to the following:

WebString WebFrameImpl::markerTextForListItem(const WebElement& element) const
{
    return WebCore::markerTextForListItem(element.unwrap<Element>());
}

[Dumitru Daniliuc]

Created attachment 65648 [details]
patch

[WebKit Review Bot]

Attachment 65648 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/3865003

[Darin Fisher (:fishd, Google)]

Comment on attachment 65648 [details]
patch

WebKit/chromium/src/WebFrameImpl.h:179
 +      virtual WebString markerTextForListItem(const WebElement& webElement) const;
nit: no parameter name here.

R=me w/ that fix

[Dumitru Daniliuc]

(In reply to comment #5)
> (From update of attachment 65648 [details])
> WebKit/chromium/src/WebFrameImpl.h:179
>  +      virtual WebString markerTextForListItem(const WebElement& webElement) const;
> nit: no parameter name here.
> 
> R=me w/ that fix

done.

[WebKit Review Bot]

http://trac.webkit.org/changeset/66176 might have broken Chromium Linux Release

[Dumitru Daniliuc]

landed: r66176. fixed the build breakage in r66180.