Bug 44724

Summary:

[Chromium] Implement LayoutTestController::markerTextForListItem()

Product:

WebKit

Reporter:

Dumitru Daniliuc <dumi>

Component:

New Bugs

Assignee:

Dumitru Daniliuc <dumi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dglazkov, eric, fishd, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	fishd: review-, dumi: commit-queue-
patch	fishd: review+, dumi: commit-queue-

Dumitru Daniliuc

Reported 2010-08-26 15:14:08 PDT

Add markerTextForListItem() to Chromium's LayoutTestController.

Attachments
patch (5.38 KB, patch) 2010-08-26 16:14 PDT, Dumitru Daniliuc	fishd: review- dumi: commit-queue-	Details Formatted Diff Diff
patch (5.32 KB, patch) 2010-08-26 17:13 PDT, Dumitru Daniliuc	fishd: review+ dumi: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Dumitru Daniliuc

Comment 1 2010-08-26 16:14:39 PDT

Created attachment 65641 [details] patch WebKit's side of the patch. Chromium's side is at http://codereview.chromium.org/3213001.

Darin Fisher (:fishd, Google)

Comment 2 2010-08-26 16:49:08 PDT

Comment on attachment 65641 [details] patch WebKit/chromium/public/WebFrame.h:522 + virtual WebString markerTextForListItem(const WebElement& webElement) const = 0; nit: no parameter name here since the parameter name does not add information. WebKit/chromium/src/WebFrameImpl.cpp:1696 + return WebCore::markerTextForListItem(element.get()); nit: change this to the following: WebString WebFrameImpl::markerTextForListItem(const WebElement& element) const { return WebCore::markerTextForListItem(element.unwrap<Element>()); }

Dumitru Daniliuc

Comment 3 2010-08-26 17:13:52 PDT

Created attachment 65648 [details] patch

WebKit Review Bot

Comment 4 2010-08-26 19:23:30 PDT

Attachment 65648 [details] did not build on chromium: Build output: http://queues.webkit.org/results/3865003

Darin Fisher (:fishd, Google)

Comment 5 2010-08-26 20:33:31 PDT

Comment on attachment 65648 [details] patch WebKit/chromium/src/WebFrameImpl.h:179 + virtual WebString markerTextForListItem(const WebElement& webElement) const; nit: no parameter name here. R=me w/ that fix

Dumitru Daniliuc

Comment 6 2010-08-26 20:37:12 PDT

(In reply to comment #5) > (From update of attachment 65648 [details]) > WebKit/chromium/src/WebFrameImpl.h:179 > + virtual WebString markerTextForListItem(const WebElement& webElement) const; > nit: no parameter name here. > > R=me w/ that fix done.

WebKit Review Bot

Comment 7 2010-08-26 21:08:28 PDT

http://trac.webkit.org/changeset/66176 might have broken Chromium Linux Release

Dumitru Daniliuc

Comment 8 2010-08-26 21:34:35 PDT

landed: r66176. fixed the build breakage in r66180.

Note You need to log in before you can comment on or make changes to this bug.