Bug 44720

Summary:

Remove unnecessary AlphaBlend in PasteboardWin

Product:

WebKit

Reporter:

Patrick R. Gansterer <paroga>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aroben, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	aroben: review-, aroben: commit-queue-
Patch	aroben: review-, aroben: commit-queue-
Patch	none

Patrick R. Gansterer

Reported 2010-08-26 14:47:49 PDT

see patch

Attachments
Patch (1.47 KB, patch) 2010-08-26 14:52 PDT, Patrick R. Gansterer	aroben: review- aroben: commit-queue-	Details Formatted Diff Diff
Patch (1.68 KB, patch) 2010-08-26 15:00 PDT, Patrick R. Gansterer	aroben: review- aroben: commit-queue-	Details Formatted Diff Diff
Patch (1.68 KB, patch) 2010-08-26 15:04 PDT, Patrick R. Gansterer	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Patrick R. Gansterer

Comment 1 2010-08-26 14:52:18 PDT

Created attachment 65621 [details] Patch

Adam Roben (:aroben)

Comment 2 2010-08-26 14:55:12 PDT

Comment on attachment 65621 [details] Patch I think it would be good to mention in the ChangeLog that testing showed that alpha never survives copy-and-paste on Windows in any browser, and that StretchBlt was overkill since the source and destination size were always equal. Other than that this looks great!

Patrick R. Gansterer

Comment 3 2010-08-26 15:00:32 PDT

Created attachment 65623 [details] Patch

Adam Roben (:aroben)

Comment 4 2010-08-26 15:01:54 PDT

Comment on attachment 65623 [details] Patch > + Replacing AlphaBlend with BitBlt is save because testing showed that alpha Typo: save (should be "safe") > + never survives copy-and-paste on Windows in any browser, and StretchBlt > + was a overkill since the source and destination size are always equal. Typo: a overkill (should be "overkill") Soooo close!

Patrick R. Gansterer

Comment 5 2010-08-26 15:04:43 PDT

Created attachment 65624 [details] Patch

Adam Roben (:aroben)

Comment 6 2010-08-26 15:05:48 PDT

Comment on attachment 65624 [details] Patch r=me

WebKit Commit Bot

Comment 7 2010-08-27 18:59:17 PDT

Comment on attachment 65624 [details] Patch Clearing flags on attachment: 65624 Committed r66291: <http://trac.webkit.org/changeset/66291>

WebKit Commit Bot

Comment 8 2010-08-27 18:59:22 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.