Bug 44693

Summary: [WINCE] Port SoftLinking to WinCE
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, commit-queue, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Patch
aroben: review+, aroben: commit-queue-
Patch none

Patrick R. Gansterer
Reported 2010-08-26 09:30:35 PDT
WinCE provides GetProcAddressW and GetProcAddressA for softlinking. Unfortunately WinNT provides only GetProcAddress (without A or W).
Attachments
Patch (2.17 KB, patch)
2010-08-26 13:50 PDT, Patrick R. Gansterer 		aroben: review+
aroben: commit-queue-
DetailsFormatted DiffDiff
Patch (2.08 KB, patch)
2010-08-26 14:46 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2010-08-26 13:50:16 PDT
Created attachment 65614 [details] Patch
WebKit Review Bot
Comment 2 2010-08-26 13:51:18 PDT
Attachment 65614 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/win/SoftLinking.h:57: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Adam Roben (:aroben)
Comment 3 2010-08-26 14:24:20 PDT
Comment on attachment 65614 [details] Patch > + Add a platformdependent macro for GetProcAddress. Typo: platformdependent > +#if OS(WINCE) > +#define SOFT_LINK_GETPROCADDRESS(library, functionName) GetProcAddressW(library##Library(), L###functionName) > +#else > +#define SOFT_LINK_GETPROCADDRESS(library, functionName) GetProcAddress(library##Library(), #functionName) > +#endif Should we use GetProcAddressA on WinCE? GetProcAddress on NT is ANSI-only IIRC. r+ since the code looks fine, but you should consider the above.
Patrick R. Gansterer
Comment 4 2010-08-26 14:46:39 PDT
Created attachment 65620 [details] Patch
WebKit Review Bot
Comment 5 2010-08-26 14:48:50 PDT
Attachment 65620 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/win/SoftLinking.h:57: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Adam Roben (:aroben)
Comment 6 2010-08-26 14:55:26 PDT
Comment on attachment 65620 [details] Patch r=me
WebKit Commit Bot
Comment 7 2010-08-27 17:55:24 PDT
Comment on attachment 65620 [details] Patch Clearing flags on attachment: 65620 Committed r66286: <http://trac.webkit.org/changeset/66286>
WebKit Commit Bot
Comment 8 2010-08-27 17:55:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.