Bug 44687

Summary:

Web Inspector: use context menu items with checkbox for DOM breakpoints

Product:

WebKit

Reporter:

Pavel Podivilov <podivilov>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

pfeldman

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Proposed patch.	none
Proposed patch.	none
Proposed patch.	none
Proposed patch.	pfeldman: review-
Proposed patch.	pfeldman: review+

Pavel Podivilov

Reported 2010-08-26 08:25:22 PDT

Web Inspector: use context menu items with checkbox for setting and removing DOM breakpoints

Attachments
Proposed patch. (4.61 KB, patch) 2010-08-26 08:29 PDT, Pavel Podivilov	no flags	Details Formatted Diff Diff
Proposed patch. (5.50 KB, patch) 2010-08-26 08:48 PDT, Pavel Podivilov	no flags	Details Formatted Diff Diff
Proposed patch. (5.75 KB, patch) 2010-08-26 08:49 PDT, Pavel Podivilov	no flags	Details Formatted Diff Diff
Proposed patch. (5.72 KB, patch) 2010-08-26 08:53 PDT, Pavel Podivilov	pfeldman: review-	Details Formatted Diff Diff
Proposed patch. (7.66 KB, patch) 2010-08-26 09:14 PDT, Pavel Podivilov	pfeldman: review+	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Pavel Podivilov

Comment 1 2010-08-26 08:29:19 PDT

Created attachment 65568 [details] Proposed patch.

Pavel Podivilov

Comment 2 2010-08-26 08:48:44 PDT

Created attachment 65570 [details] Proposed patch.

Pavel Podivilov

Comment 3 2010-08-26 08:49:29 PDT

Created attachment 65571 [details] Proposed patch.

Pavel Podivilov

Comment 4 2010-08-26 08:53:38 PDT

Created attachment 65572 [details] Proposed patch.

Pavel Feldman

Comment 5 2010-08-26 08:57:15 PDT

Comment on attachment 65572 [details] Proposed patch. WebCore/inspector/front-end/DOMAgent.js:743 + WebInspector.DOMBreakpoint.ContextMenuLabels = {}; This slows down our load time, please do it lazily.

Pavel Podivilov

Comment 6 2010-08-26 09:14:55 PDT

Created attachment 65574 [details] Proposed patch.

Pavel Feldman

Comment 7 2010-08-27 06:39:10 PDT

Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/English.lproj/localizedStrings.js M WebCore/inspector/front-end/BreakpointsSidebarPane.js M WebCore/inspector/front-end/DOMAgent.js M WebCore/inspector/front-end/ElementsTreeOutline.js M WebCore/inspector/front-end/inspector.js Committed r66213

Note You need to log in before you can comment on or make changes to this bug.