Bug 44687

Summary: Web Inspector: use context menu items with checkbox for DOM breakpoints
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: pfeldman
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Proposed patch.
none
Proposed patch.
none
Proposed patch.
none
Proposed patch.
pfeldman: review-
Proposed patch. pfeldman: review+

Description Pavel Podivilov 2010-08-26 08:25:22 PDT 
Web Inspector: use context menu items with checkbox for setting and removing DOM breakpoints
Comment 1 Pavel Podivilov 2010-08-26 08:29:19 PDT 
Created attachment 65568 [details]
Proposed patch.
Comment 2 Pavel Podivilov 2010-08-26 08:48:44 PDT 
Created attachment 65570 [details]
Proposed patch.
Comment 3 Pavel Podivilov 2010-08-26 08:49:29 PDT 
Created attachment 65571 [details]
Proposed patch.
Comment 4 Pavel Podivilov 2010-08-26 08:53:38 PDT 
Created attachment 65572 [details]
Proposed patch.
Comment 5 Pavel Feldman 2010-08-26 08:57:15 PDT 
Comment on attachment 65572 [details]
Proposed patch.

WebCore/inspector/front-end/DOMAgent.js:743
 +  WebInspector.DOMBreakpoint.ContextMenuLabels = {};
This slows down our load time, please do it lazily.
Comment 6 Pavel Podivilov 2010-08-26 09:14:55 PDT 
Created attachment 65574 [details]
Proposed patch.
Comment 7 Pavel Feldman 2010-08-27 06:39:10 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/English.lproj/localizedStrings.js
	M	WebCore/inspector/front-end/BreakpointsSidebarPane.js
	M	WebCore/inspector/front-end/DOMAgent.js
	M	WebCore/inspector/front-end/ElementsTreeOutline.js
	M	WebCore/inspector/front-end/inspector.js
Committed r66213