Bug 44673

Summary: Web Inspector: scripts are pushed to front-end before resources
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Severity: Normal CC: abarth, commit-queue, eric, pfeldman, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Description Flags
Proposed patch.
Proposed patch. commit-queue: commit-queue-

Description Pavel Podivilov 2010-08-26 03:15:57 PDT
Web Inspector: scripts are pushed to front-end before resources
Comment 1 Pavel Podivilov 2010-08-26 03:29:55 PDT
Created attachment 65539 [details]
Proposed patch.
Comment 2 WebKit Review Bot 2010-08-26 03:34:21 PDT
Attachment 65539 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/inspector/InspectorController.cpp:665:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 1 in 2 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Pavel Podivilov 2010-08-26 03:42:03 PDT
Created attachment 65541 [details]
Proposed patch.
Comment 4 Pavel Feldman 2010-08-26 03:56:07 PDT
Comment on attachment 65541 [details]
Proposed patch.

Clearing flags on attachment: 65541

Committed r66094: <http://trac.webkit.org/changeset/66094>
Comment 5 Pavel Feldman 2010-08-26 03:56:17 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Commit Bot 2010-08-26 04:30:07 PDT
Comment on attachment 65541 [details]
Proposed patch.

Rejecting patch 65541 from commit-queue.

Unexpected failure when processing patch!  Please file a bug against webkit-patch.
Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 65541, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1
Last 500 characters of output:
Fetching: https://bugs.webkit.org/show_bug.cgi?id=44673&ctype=xml
Processing 1 patch from 1 bug.
Cleaning working directory
Processing patch 65541 from bug 44673.
NOBODY (OOPS!) found in /Users/eseidel/Projects/CommitQueue/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /Users/eseidel/Projects/CommitQueue/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 7 WebKit Review Bot 2010-08-26 04:34:41 PDT
http://trac.webkit.org/changeset/66094 might have broken GTK Linux 64-bit Debug
The following changes are on the blame list: