Bug 44646

Summary: test conversion: editing/style/typing-style-003.html should use runDumpAsTextEditingTest instead of runEditingTest
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Blocker CC: abarth, enrica, eric, ojan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 44560    
Attachments:
Description Flags
converts the test tony: review+

Ryosuke Niwa
Reported 2010-08-25 16:19:29 PDT
editing/style/typing-style-003.html is testing the behavior of typing style but we cannot see whether or not correct sequence of DOM modifications are done with runEditingTest. Furthermore, we don't have to test the correctness of rendering at all. We should call runDumpAsTextEditingTest instead so that we can test each DOM modification step.
Attachments
converts the test (42.42 KB, patch)
2010-08-25 16:30 PDT, Ryosuke Niwa 		tony: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2010-08-25 16:30:38 PDT
Created attachment 65496 [details] converts the test
Ryosuke Niwa
Comment 2 2010-08-25 16:56:04 PDT
Committed r66056: <http://trac.webkit.org/changeset/66056>
WebKit Review Bot
Comment 3 2010-08-25 18:52:29 PDT
http://trac.webkit.org/changeset/66056 might have broken GTK Linux 32-bit Release and GTK Linux 64-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/66056 http://trac.webkit.org/changeset/66057 http://trac.webkit.org/changeset/66058 http://trac.webkit.org/changeset/66060 http://trac.webkit.org/changeset/66053
Note You need to log in before you can comment on or make changes to this bug.