Bug 44645

Summary:

[BREWMP] Add build system

Product:

WebKit

Reporter:

Kwang Yul Seo <skyul>

Component:

WebCore Misc.

Assignee:

Kwang Yul Seo <skyul>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

beergun, commit-queue, eric, joybro201, kevino, xhiloh

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Other

Bug Depends on:

Bug Blocks:

33564

Attachments:

Description	Flags
wscript	none
wscript (JavaScriptCore)	none
wscript	none

Description Kwang Yul Seo 2010-08-25 16:09:58 PDT

Add build system for BrewMP port.

Comment 1 Kwang Yul Seo 2010-08-25 16:19:04 PDT

Created attachment 65494 [details]
wscript

BrewMP will use waf as its build system. Before I upstream the build system for Brew MP, I want to make the current wscript (wx port) more portable.

Comment 2 Kwang Yul Seo 2010-08-25 16:34:59 PDT

Created attachment 65497 [details]
wscript (JavaScriptCore)

Check build_port.

Comment 3 Kevin Ollivier 2010-08-25 17:46:02 PDT

These look good to me, thanks! :)

Comment 4 WebKit Commit Bot 2010-08-25 20:25:46 PDT

Comment on attachment 65494 [details]
wscript

Clearing flags on attachment: 65494

Committed r66076: <http://trac.webkit.org/changeset/66076>

Comment 5 WebKit Commit Bot 2010-08-25 20:41:21 PDT

Comment on attachment 65497 [details]
wscript (JavaScriptCore)

Clearing flags on attachment: 65497

Committed r66078: <http://trac.webkit.org/changeset/66078>

Comment 6 WebKit Commit Bot 2010-08-25 20:41:25 PDT

All reviewed patches have been landed.  Closing bug.

Comment 7 Kwang Yul Seo 2010-08-27 05:27:24 PDT

Created attachment 65702 [details]
wscript

Check Options.options.wxpython only if build_port is "wx".

Comment 8 Kwang Yul Seo 2010-08-27 05:28:33 PDT

Reopen the bug as more patches are coming. How can I prevent the bug from being closed automatically?

Comment 9 Kevin Ollivier 2010-08-28 16:02:30 PDT

Landed the latest patch in r66315. Not using the commit queue is the only way I know of to avoid having it close the bug when all patches have been applied.

Comment 10 WebKit Commit Bot 2010-09-15 01:27:07 PDT

Comment on attachment 65702 [details]
wscript

Rejecting patch 65702 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Kevin Ollivier', u'--force']" exit_code: 1
Parsed 2 diffs from patch file(s).
patching file ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file wscript
Hunk #1 FAILED at 181.
1 out of 1 hunk FAILED -- saving rejects to file wscript.rej

Full output: http://queues.webkit.org/results/3998021

Comment 11 Kwang Yul Seo 2010-09-15 09:57:17 PDT

(In reply to comment #10)
> (From update of attachment 65702 [details])
> Rejecting patch 65702 from commit-queue.
> 
> Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Kevin Ollivier', u'--force']" exit_code: 1
> Parsed 2 diffs from patch file(s).
> patching file ChangeLog
> Hunk #1 succeeded at 1 with fuzz 3.
> patching file wscript
> Hunk #1 FAILED at 181.
> 1 out of 1 hunk FAILED -- saving rejects to file wscript.rej
> 
> Full output: http://queues.webkit.org/results/3998021

Oops. The patch was already submitted by Kevin. Sorry for not clearing "r+" flag.

Comment 12 Eric Seidel (no email) 2010-10-13 12:25:30 PDT

Attachment 65702 [details] was posted by a committer and has review+, assigning to Kwang Yul Seo for commit.

Comment 13 Kwang Yul Seo 2010-10-13 17:57:01 PDT

Comment on attachment 65702 [details]
wscript

Clear flags because it is already committed.

Comment 14 Kwang Yul Seo 2012-07-26 05:21:19 PDT

Brew MP port is no longer maintained.