Bug 44624

Summary: [GTK] The GNUmakefile.am files contain a myriad of confusing preprocessor and compiler flag definitions
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Gtk
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Clean up patch none

Description Martin Robinson 2010-08-25 11:07:40 PDT
I cannot keep track of which flags apply to which project. It also appears that some include lines are duplicated, because they are defined in the top-level file and the project specific file. This bug tracks the cleanup.
Comment 1 Martin Robinson 2010-08-25 11:16:52 PDT
Created attachment 65445 [details]
Clean up patch
Comment 2 Xan Lopez 2010-08-26 08:53:50 PDT
Comment on attachment 65445 [details]
Clean up patch

LGTM!
Comment 3 Martin Robinson 2010-08-26 09:16:19 PDT
Comment on attachment 65445 [details]
Clean up patch

Clearing flags on attachment: 65445

Committed r66108: <http://trac.webkit.org/changeset/66108>
Comment 4 Martin Robinson 2010-08-26 09:16:23 PDT
All reviewed patches have been landed.  Closing bug.