Bug 44624

Summary:

[GTK] The GNUmakefile.am files contain a myriad of confusing preprocessor and compiler flag definitions

Product:

WebKit

Reporter:

Martin Robinson <mrobinson>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

Gtk

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
Clean up patch	none

Martin Robinson

Reported 2010-08-25 11:07:40 PDT

I cannot keep track of which flags apply to which project. It also appears that some include lines are duplicated, because they are defined in the top-level file and the project specific file. This bug tracks the cleanup.

Attachments
Clean up patch (12.40 KB, patch) 2010-08-25 11:16 PDT, Martin Robinson	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Martin Robinson

Comment 1 2010-08-25 11:16:52 PDT

Created attachment 65445 [details] Clean up patch

Xan Lopez

Comment 2 2010-08-26 08:53:50 PDT

Comment on attachment 65445 [details] Clean up patch LGTM!

Martin Robinson

Comment 3 2010-08-26 09:16:19 PDT

Comment on attachment 65445 [details] Clean up patch Clearing flags on attachment: 65445 Committed r66108: <http://trac.webkit.org/changeset/66108>

Martin Robinson

Comment 4 2010-08-26 09:16:23 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.