Bug 44624 - [GTK] The GNUmakefile.am files contain a myriad of confusing preprocessor and compiler flag definitions
Summary: [GTK] The GNUmakefile.am files contain a myriad of confusing preprocessor and...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2010-08-25 11:07 PDT by Martin Robinson
Modified: 2010-08-26 09:16 PDT (History)
0 users

See Also:


Attachments
Clean up patch (12.40 KB, patch)
2010-08-25 11:16 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2010-08-25 11:07:40 PDT
I cannot keep track of which flags apply to which project. It also appears that some include lines are duplicated, because they are defined in the top-level file and the project specific file. This bug tracks the cleanup.
Comment 1 Martin Robinson 2010-08-25 11:16:52 PDT
Created attachment 65445 [details]
Clean up patch
Comment 2 Xan Lopez 2010-08-26 08:53:50 PDT
Comment on attachment 65445 [details]
Clean up patch

LGTM!
Comment 3 Martin Robinson 2010-08-26 09:16:19 PDT
Comment on attachment 65445 [details]
Clean up patch

Clearing flags on attachment: 65445

Committed r66108: <http://trac.webkit.org/changeset/66108>
Comment 4 Martin Robinson 2010-08-26 09:16:23 PDT
All reviewed patches have been landed.  Closing bug.