Bug 44601

Summary: Web Inspector: support disabled and checked context menu items.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, joepeck, keishi, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed change.
yurys: review-
[PATCH] Proposed change.
yurys: review+
[PATCH] Proposed change. none

Pavel Feldman
Reported 2010-08-25 05:02:05 PDT
Patch to follow.
Attachments
[PATCH] Proposed change. (5.95 KB, patch)
2010-08-25 05:06 PDT, Pavel Feldman 		yurys: review-
DetailsFormatted DiffDiff
[PATCH] Proposed change. (6.29 KB, patch)
2010-08-25 05:17 PDT, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
[PATCH] Proposed change. (8.36 KB, patch)
2010-08-25 06:13 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2010-08-25 05:06:40 PDT
Created attachment 65401 [details] [PATCH] Proposed change.
Yury Semikhatsky
Comment 2 2010-08-25 05:13:33 PDT
Comment on attachment 65401 [details] [PATCH] Proposed change. WebCore/inspector/front-end/ContextMenu.js:52 + this._items.push({id: id, label: label, checked: checked, enabled: !!disabled}); !!disabled -> !disabled
Pavel Feldman
Comment 3 2010-08-25 05:17:51 PDT
Created attachment 65403 [details] [PATCH] Proposed change.
Yury Semikhatsky
Comment 4 2010-08-25 05:19:32 PDT
Comment on attachment 65403 [details] [PATCH] Proposed change. WebCore/inspector/front-end/ContextMenu.js:49 + appendItem: function(label, handler, checked, disabled) I'd rather pass explicit enabled parameter.
Pavel Feldman
Comment 5 2010-08-25 06:13:37 PDT
Created attachment 65407 [details] [PATCH] Proposed change.
Pavel Feldman
Comment 6 2010-08-25 06:50:49 PDT
Variation of patch landed. Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/English.lproj/localizedStrings.js M WebCore/bindings/js/JSInspectorFrontendHostCustom.cpp M WebCore/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp M WebCore/inspector/front-end/ConsoleView.js M WebCore/inspector/front-end/ContextMenu.js Committed r66010
Note You need to log in before you can comment on or make changes to this bug.