Bug 44601 - Web Inspector: support disabled and checked context menu items.
Summary: Web Inspector: support disabled and checked context menu items.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-25 05:02 PDT by Pavel Feldman
Modified: 2010-08-25 06:50 PDT (History)
8 users (show)

See Also:


Attachments
[PATCH] Proposed change. (5.95 KB, patch)
2010-08-25 05:06 PDT, Pavel Feldman
yurys: review-
Details | Formatted Diff | Diff
[PATCH] Proposed change. (6.29 KB, patch)
2010-08-25 05:17 PDT, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff
[PATCH] Proposed change. (8.36 KB, patch)
2010-08-25 06:13 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-08-25 05:02:05 PDT
Patch to follow.
Comment 1 Pavel Feldman 2010-08-25 05:06:40 PDT
Created attachment 65401 [details]
[PATCH] Proposed change.
Comment 2 Yury Semikhatsky 2010-08-25 05:13:33 PDT
Comment on attachment 65401 [details]
[PATCH] Proposed change.

WebCore/inspector/front-end/ContextMenu.js:52
 +          this._items.push({id: id, label: label, checked: checked, enabled: !!disabled});
!!disabled -> !disabled
Comment 3 Pavel Feldman 2010-08-25 05:17:51 PDT
Created attachment 65403 [details]
[PATCH] Proposed change.
Comment 4 Yury Semikhatsky 2010-08-25 05:19:32 PDT
Comment on attachment 65403 [details]
[PATCH] Proposed change.

WebCore/inspector/front-end/ContextMenu.js:49
 +      appendItem: function(label, handler, checked, disabled)
I'd rather pass explicit enabled parameter.
Comment 5 Pavel Feldman 2010-08-25 06:13:37 PDT
Created attachment 65407 [details]
[PATCH] Proposed change.
Comment 6 Pavel Feldman 2010-08-25 06:50:49 PDT
Variation of patch landed.

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/English.lproj/localizedStrings.js
	M	WebCore/bindings/js/JSInspectorFrontendHostCustom.cpp
	M	WebCore/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp
	M	WebCore/inspector/front-end/ConsoleView.js
	M	WebCore/inspector/front-end/ContextMenu.js
Committed r66010