Bug 44585

Summary: [DRT/Chromium] Fix fast/notifications/notifications-display-close-events.html failure
Product: WebKit Reporter: Kent Tamura <tkent>
Component: Tools / TestsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: All   
Attachments:
Description Flags
Patch none

Description Kent Tamura 2010-08-24 22:54:03 PDT
[DRT/Chromium] Fix fast/notifications/notifications-display-close-events.html failure
Comment 1 Kent Tamura 2010-08-24 23:02:22 PDT
Created attachment 65374 [details]
Patch
Comment 2 Adam Barth 2010-08-30 16:50:05 PDT
Comment on attachment 65374 [details]
Patch

> WebKitTools/DumpRenderTree/chromium/NotificationPresenter.cpp:50
> +static void deferredDisplayDispatch(WebNotification notification)
> +{
> +    notification.dispatchDisplayEvent();
> +}
We really would like to have RunnableMethods, huh?
Comment 3 Kent Tamura 2010-08-30 17:17:58 PDT
(In reply to comment #2)
> (From update of attachment 65374 [details])
> > WebKitTools/DumpRenderTree/chromium/NotificationPresenter.cpp:50
> > +static void deferredDisplayDispatch(WebNotification notification)
> > +{
> > +    notification.dispatchDisplayEvent();
> > +}
> We really would like to have RunnableMethods, huh?

Probably.  Anyway, we need to revisit here to remove base/task.h dependency.
Comment 4 Kent Tamura 2010-08-30 17:19:26 PDT
Comment on attachment 65374 [details]
Patch

Clearing flags on attachment: 65374

Committed r66430: <http://trac.webkit.org/changeset/66430>
Comment 5 Kent Tamura 2010-08-30 17:19:34 PDT
All reviewed patches have been landed.  Closing bug.