Summary: | [DRT/Chromium] Fix fast/notifications/notifications-display-close-events.html failure | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||
Component: | Tools / Tests | Assignee: | Kent Tamura <tkent> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dglazkov, tony | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Kent Tamura
2010-08-24 22:54:03 PDT
Created attachment 65374 [details]
Patch
Comment on attachment 65374 [details] Patch > WebKitTools/DumpRenderTree/chromium/NotificationPresenter.cpp:50 > +static void deferredDisplayDispatch(WebNotification notification) > +{ > + notification.dispatchDisplayEvent(); > +} We really would like to have RunnableMethods, huh? (In reply to comment #2) > (From update of attachment 65374 [details]) > > WebKitTools/DumpRenderTree/chromium/NotificationPresenter.cpp:50 > > +static void deferredDisplayDispatch(WebNotification notification) > > +{ > > + notification.dispatchDisplayEvent(); > > +} > We really would like to have RunnableMethods, huh? Probably. Anyway, we need to revisit here to remove base/task.h dependency. Comment on attachment 65374 [details] Patch Clearing flags on attachment: 65374 Committed r66430: <http://trac.webkit.org/changeset/66430> All reviewed patches have been landed. Closing bug. |