Bug 44572

Summary: [Chromium] Hulu popups are blocked
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch dglazkov: review+, dglazkov: commit-queue-

Adam Barth
Reported 2010-08-24 18:28:58 PDT
[Chromium] Hulu popups are blocked
Attachments
Patch (1.88 KB, patch)
2010-08-24 18:32 PDT, Adam Barth 		dglazkov: review+
dglazkov: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-08-24 18:32:25 PDT
Created attachment 65355 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2010-08-24 18:40:35 PDT
Comment on attachment 65355 [details] Patch WebKit/chromium/ChangeLog:9 + setting the UserGestureIndictor for events. Most WebKit ports handle Indicator WebKit/chromium/ChangeLog:16 + the ability to run the Chromium LayoutTests on this machine. :( Why not?
Adam Barth
Comment 3 2010-08-24 18:46:10 PDT
> + the ability to run the Chromium LayoutTests on this machine. :( > Why not? I almost never build Chrome and build-webkit --chromium can't run the tests, AFAIK.
Adam Barth
Comment 4 2010-08-24 18:49:39 PDT
Committed r65964: <http://trac.webkit.org/changeset/65964>
Dimitri Glazkov (Google)
Comment 5 2010-08-24 18:50:39 PDT
(In reply to comment #3) > > + the ability to run the Chromium LayoutTests on this machine. :( > > Why not? > > I almost never build Chrome and build-webkit --chromium can't run the tests, AFAIK. Yes we can! http://build.webkit.org/builders/Chromium%20Mac%20Release%20(Tests)/builds/1602/steps/layout-test/logs/stdio
Adam Barth
Comment 6 2010-08-24 19:12:26 PDT
That's exciting. I'll try that next time.
Note You need to log in before you can comment on or make changes to this bug.