| Summary: | [Chromium] Hulu popups are blocked | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
| Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, dglazkov, eric, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Adam Barth
2010-08-24 18:28:58 PDT
Created attachment 65355 [details]
Patch
Comment on attachment 65355 [details]
Patch
WebKit/chromium/ChangeLog:9
+ setting the UserGestureIndictor for events. Most WebKit ports handle
Indicator
WebKit/chromium/ChangeLog:16
+ the ability to run the Chromium LayoutTests on this machine. :(
Why not?
> + the ability to run the Chromium LayoutTests on this machine. :(
> Why not?
I almost never build Chrome and build-webkit --chromium can't run the tests, AFAIK.
Committed r65964: <http://trac.webkit.org/changeset/65964> (In reply to comment #3) > > + the ability to run the Chromium LayoutTests on this machine. :( > > Why not? > > I almost never build Chrome and build-webkit --chromium can't run the tests, AFAIK. Yes we can! http://build.webkit.org/builders/Chromium%20Mac%20Release%20(Tests)/builds/1602/steps/layout-test/logs/stdio That's exciting. I'll try that next time. http://trac.webkit.org/changeset/65964 might have broken SnowLeopard Intel Release (Tests) The following changes are on the blame list: http://trac.webkit.org/changeset/65960 http://trac.webkit.org/changeset/65961 http://trac.webkit.org/changeset/65962 http://trac.webkit.org/changeset/65963 http://trac.webkit.org/changeset/65964 http://trac.webkit.org/changeset/65965 |