WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
44572
[Chromium] Hulu popups are blocked
https://bugs.webkit.org/show_bug.cgi?id=44572
Summary
[Chromium] Hulu popups are blocked
Adam Barth
Reported
2010-08-24 18:28:58 PDT
[Chromium] Hulu popups are blocked
Attachments
Patch
(1.88 KB, patch)
2010-08-24 18:32 PDT
,
Adam Barth
dglazkov
: review+
dglazkov
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2010-08-24 18:32:25 PDT
Created
attachment 65355
[details]
Patch
Dimitri Glazkov (Google)
Comment 2
2010-08-24 18:40:35 PDT
Comment on
attachment 65355
[details]
Patch WebKit/chromium/ChangeLog:9 + setting the UserGestureIndictor for events. Most WebKit ports handle Indicator WebKit/chromium/ChangeLog:16 + the ability to run the Chromium LayoutTests on this machine. :( Why not?
Adam Barth
Comment 3
2010-08-24 18:46:10 PDT
> + the ability to run the Chromium LayoutTests on this machine. :( > Why not?
I almost never build Chrome and build-webkit --chromium can't run the tests, AFAIK.
Adam Barth
Comment 4
2010-08-24 18:49:39 PDT
Committed
r65964
: <
http://trac.webkit.org/changeset/65964
>
Dimitri Glazkov (Google)
Comment 5
2010-08-24 18:50:39 PDT
(In reply to
comment #3
)
> > + the ability to run the Chromium LayoutTests on this machine. :( > > Why not? > > I almost never build Chrome and build-webkit --chromium can't run the tests, AFAIK.
Yes we can!
http://build.webkit.org/builders/Chromium%20Mac%20Release%20(Tests)/builds/1602/steps/layout-test/logs/stdio
Adam Barth
Comment 6
2010-08-24 19:12:26 PDT
That's exciting. I'll try that next time.
WebKit Review Bot
Comment 7
2010-08-24 19:29:32 PDT
http://trac.webkit.org/changeset/65964
might have broken SnowLeopard Intel Release (Tests) The following changes are on the blame list:
http://trac.webkit.org/changeset/65960
http://trac.webkit.org/changeset/65961
http://trac.webkit.org/changeset/65962
http://trac.webkit.org/changeset/65963
http://trac.webkit.org/changeset/65964
http://trac.webkit.org/changeset/65965
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug