Bug 44572 - [Chromium] Hulu popups are blocked
Summary: [Chromium] Hulu popups are blocked
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-24 18:28 PDT by Adam Barth
Modified: 2010-08-24 19:29 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.88 KB, patch)
2010-08-24 18:32 PDT, Adam Barth 		dglazkov: review+
dglazkov: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-08-24 18:28:58 PDT 
[Chromium] Hulu popups are blocked
Comment 1 Adam Barth 2010-08-24 18:32:25 PDT 
Created attachment 65355 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2010-08-24 18:40:35 PDT 
Comment on attachment 65355 [details]
Patch

WebKit/chromium/ChangeLog:9
 +          setting the UserGestureIndictor for events.  Most WebKit ports handle
Indicator

WebKit/chromium/ChangeLog:16
 +          the ability to run the Chromium LayoutTests on this machine.  :(
Why not?
Comment 3 Adam Barth 2010-08-24 18:46:10 PDT 
>  +          the ability to run the Chromium LayoutTests on this machine.  :(
> Why not?

I almost never build Chrome and build-webkit --chromium can't run the tests, AFAIK.
Comment 4 Adam Barth 2010-08-24 18:49:39 PDT 
Committed r65964: <http://trac.webkit.org/changeset/65964>
Comment 5 Dimitri Glazkov (Google) 2010-08-24 18:50:39 PDT 
(In reply to comment #3)
> >  +          the ability to run the Chromium LayoutTests on this machine.  :(
> > Why not?
> 
> I almost never build Chrome and build-webkit --chromium can't run the tests, AFAIK.

Yes we can!

http://build.webkit.org/builders/Chromium%20Mac%20Release%20(Tests)/builds/1602/steps/layout-test/logs/stdio
Comment 6 Adam Barth 2010-08-24 19:12:26 PDT 
That's exciting.  I'll try that next time.