Bug 44565

Summary: [GTK] WebKitGTK+ needs proper introspection annotation for most types and methods
Product: WebKit Reporter: Gustavo Noronha (kov) <gustavo>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: alan, mrobinson, xan.lopez
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
first smallish set of annotations none

Gustavo Noronha (kov)
Reported 2010-08-24 17:02:08 PDT
That's about it. Code such as this makes programs written using Introspection crash: from gi.repository import WebKit wv = WebKit.WebView() settings = wv.get_settings() settings = wv.get_settings() Because the introspection information that is generated naively assumes that get_settings returns a new ref, and unrefs it. Assuming ownership and transfer information is just dumb IMO, but not really important for this bug - I'll use this bug to drop many patches implementing proper annotations.
Attachments
first smallish set of annotations (3.54 KB, patch)
2010-08-24 17:04 PDT, Gustavo Noronha (kov) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gustavo Noronha (kov)
Comment 1 2010-08-24 17:04:29 PDT
Created attachment 65345 [details] first smallish set of annotations
Martin Robinson
Comment 2 2010-08-25 11:03:59 PDT
Comment on attachment 65345 [details] first smallish set of annotations Great documentation improvements too. LGTM.
Gustavo Noronha (kov)
Comment 3 2010-08-26 06:12:15 PDT
Comment on attachment 65345 [details] first smallish set of annotations Clearing flags on attachment: 65345 Committed r66099: <http://trac.webkit.org/changeset/66099>
Gustavo Noronha (kov)
Comment 4 2010-08-26 06:12:24 PDT
All reviewed patches have been landed. Closing bug.
Gustavo Noronha (kov)
Comment 5 2010-08-26 06:15:54 PDT
I'll keep this bug open to drop the other patches in it when I'm through with them!
Alan Knowles
Comment 6 2011-02-01 21:36:53 PST
*** Bug 40460 has been marked as a duplicate of this bug. ***
Martin Robinson
Comment 7 2014-04-08 18:40:20 PDT
Pretty sure we can close this now.
Note You need to log in before you can comment on or make changes to this bug.